You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/05/29 02:19:36 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
dongjoon-hyun opened a new pull request, #41354:
URL: https://github.com/apache/spark/pull/41354
### What changes were proposed in this pull request?
This PR aims to setup Scala 2.12 Daily GitHub Action Job by converting Scala 2.13 Daily Job.
### Why are the changes needed?
To keep the Scala 2.12 test coverage
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a daily job. We need to check after merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41354:
URL: https://github.com/apache/spark/pull/41354#issuecomment-1567615960
Should probably hold on making Scala 2.13 by default for now. it'd be a breaking change to the end users of using `pip install pyspark`, and they wouldn't have a workaround to avoid that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41354:
URL: https://github.com/apache/spark/pull/41354#issuecomment-1566436533
Thank you, @yaooqinn and @LuciferYang .
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41354:
URL: https://github.com/apache/spark/pull/41354#issuecomment-1566402280
Could you review this too, @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
URL: https://github.com/apache/spark/pull/41354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #41354: [SPARK-43845][INFRA] Setup Scala 2.12 Daily GitHub Action Job
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #41354:
URL: https://github.com/apache/spark/pull/41354#issuecomment-1568839574
@HyukjinKwon , We can keep the user-facing artifacts in Scala 2.12 independently. I mean all binaries including `pyspark`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org