You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2012/04/03 12:32:23 UTC

[jira] [Created] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

TestMRApps testSetClasspath fails
---------------------------------

                 Key: MAPREDUCE-4098
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: test
    Affects Versions: 2.0.0
            Reporter: Alejandro Abdelnur
            Assignee: Alejandro Abdelnur
             Fix For: 2.0.0


The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.

Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated MAPREDUCE-4098:
------------------------------------------

    Attachment: MAPREDUCE-4098.patch

testing for PWD to be at the beginning of the classpath and the YARN_APPLICATION_CLASSPATH to be in the classpath.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245260#comment-13245260 ] 

Alejandro Abdelnur commented on MAPREDUCE-4098:
-----------------------------------------------

@Ahmed, as you indicated, the new assertion verifies that the YARN_APPLICATION_CLASSPATH value is in the resulting classpath. If we change the default value, the test will still pass. This seems more correct than checking against a hardcoded value. I don't think we need check for hardcoded values, at least not in this test. If you see value in that, we should have an additional test checking the hardcoded value; personally I don't think such test is needed. Regarding your second comment, the check for contains is because the classpath is massaged to prefix '$PWD' and to postfix 'job.jar' and '$PWD/*'.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248380#comment-13248380 ] 

Hudson commented on MAPREDUCE-4098:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #1041 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1041/])
    MAPREDUCE-4098. TestMRApps testSetClasspath fails (tucu) (Revision 1309432)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309432
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java

                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated MAPREDUCE-4098:
------------------------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)

committed to trunk and branch-2
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246335#comment-13246335 ] 

Hudson commented on MAPREDUCE-4098:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2065 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2065/])
    MAPREDUCE-4098. TestMRApps testSetClasspath fails (tucu) (Revision 1309432)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309432
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java

                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Ahmed Radwan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245493#comment-13245493 ] 

Ahmed Radwan commented on MAPREDUCE-4098:
-----------------------------------------

+1 thanks tucu.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alejandro Abdelnur updated MAPREDUCE-4098:
------------------------------------------

    Status: Patch Available  (was: Open)
    
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248325#comment-13248325 ] 

Hudson commented on MAPREDUCE-4098:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #1006 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1006/])
    MAPREDUCE-4098. TestMRApps testSetClasspath fails (tucu) (Revision 1309432)

     Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309432
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java

                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Ahmed Radwan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245146#comment-13245146 ] 

Ahmed Radwan commented on MAPREDUCE-4098:
-----------------------------------------

So you still check for "contains" instead of equality (per your changes), but the check will remain against hardcoded classpath values?
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246383#comment-13246383 ] 

Hudson commented on MAPREDUCE-4098:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2003 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2003/])
    MAPREDUCE-4098. TestMRApps testSetClasspath fails (tucu) (Revision 1309432)

     Result = ABORTED
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309432
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java

                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245129#comment-13245129 ] 

Hadoop QA commented on MAPREDUCE-4098:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12521129/MAPREDUCE-4098.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
                  org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
                  org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
                  org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2132//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2132//console

This message is automatically generated.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245449#comment-13245449 ] 

Harsh J commented on MAPREDUCE-4098:
------------------------------------

+1, this looks good to me. Applied and test passes.

There are reported test failures. I went over them but they appear unrelated to this change. If you too reach the same conclusion, please do state so and then resolve.
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245509#comment-13245509 ] 

Alejandro Abdelnur commented on MAPREDUCE-4098:
-----------------------------------------------

Thanks Harsh. Yes, test failures seem unrelated, it looks like a zombie JVM with minicluster is around (YARN minicluster uses fixed ports)
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246338#comment-13246338 ] 

Hudson commented on MAPREDUCE-4098:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #1990 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1990/])
    MAPREDUCE-4098. TestMRApps testSetClasspath fails (tucu) (Revision 1309432)

     Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1309432
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java

                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-4098) TestMRApps testSetClasspath fails

Posted by "Ahmed Radwan (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245144#comment-13245144 ] 

Ahmed Radwan commented on MAPREDUCE-4098:
-----------------------------------------

Thanks Tucu!

The environment CLASSPATH is populated using the value for YarnConfiguration.YARN_APPLICATION_CLASSPATH from yarn-default.xml and then the test again checks if it contains the classpath from the YarnConfiguration.YARN_APPLICATION_CLASSPATH value, so the test will always succeed regardless of the value set for YarnConfiguration.YARN_APPLICATION_CLASSPATH. 

Do we need to keep the check against the hardcoded classpath values so the test will fail if they were changed in yarn-default.xml? 
                
> TestMRApps testSetClasspath fails
> ---------------------------------
>
>                 Key: MAPREDUCE-4098
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4098
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.0.0
>
>         Attachments: MAPREDUCE-4098.patch
>
>
> The assertion of this test is testing for equality, as the generated classpath file is in the classpath the test fails.
> Instead, the test should test for the expected path elements to be in the classspath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira