You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/04 05:18:00 UTC

[jira] [Commented] (AIRFLOW-3516) Improve K8 Executors Pod creation Rate

    [ https://issues.apache.org/jira/browse/AIRFLOW-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733829#comment-16733829 ] 

ASF GitHub Bot commented on AIRFLOW-3516:
-----------------------------------------

ramandumcs commented on pull request #4434: [AIRFLOW-3516] Support to create k8 worker pods in batches
URL: https://github.com/apache/incubator-airflow/pull/4434
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve K8 Executors Pod creation Rate
> --------------------------------------
>
>                 Key: AIRFLOW-3516
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3516
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: executor, kubernetes, scheduler
>    Affects Versions: 1.10.1
>            Reporter: raman
>            Assignee: raman
>            Priority: Major
>
> It seems that Airflow scheduler is creating worker pod sequentially(one pod per scheduler loop) in Kubernetes executors sync function which is called from base executors.heartbeat() function.
> One enhancement could be to create the k8 pod in batches where batch size can be configured through airflow.cfg file



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)