You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2013/10/19 02:30:01 UTC

Review Request 14767: SAMZA-9

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14767/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

removing random comments.


clean up web service on failure in app master so we don't leak non-daemon threads


make sure to start the container manager


ugrading to yarn 2.2


Diffs
-----

  build.gradle 1482ea960bb06d6b06a7dad08cc397e693c7d098 
  gradle.properties ed6390bf8c87bf07ef4da7c79eba95045c69efdc 
  gradle/dependency-versions.gradle 5f3fb326fbeecda85012c495ad41706287c92158 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala b2b529e3fab0762693a9c3d44f1b206fde92b8cb 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 7f830f21f286b72e2fcc0897f2bef22239f4dc02 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 95a6f05a74cecae10a4af69033f813f5f6f21990 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ce3fcc32a8d1743dcc0f09817601b84d7bb3a2c5 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 1a13ee5ed945d399b1cc6fca1883ae937a305f7e 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMaster.scala 14e3865afeb62b7bf2b6a9c63c294540e8b18d02 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala bde38e170bfb8d30119134b9ebc20fa04c23e541 
  samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala cbd7c1eefa081b426086e15545cdb1a5d99d8a83 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 8bf48eb5df77cc95a0a8cdd33f45680113847c6f 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala c9f70291ba436d4833a2639e8845dbca4691ff9b 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestYarnAppMaster.scala 0040648b21ebd094563cac566550c3a2dd4b24bc 

Diff: https://reviews.apache.org/r/14767/diff/


Testing
-------


Thanks,

Chris Riccomini


Re: Review Request 14767: SAMZA-9

Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14767/
-----------------------------------------------------------

(Updated Oct. 21, 2013, 3:51 p.m.)


Review request for samza.


Repository: samza


Description (updated)
-------

adding an application type.


removing random comments.


clean up web service on failure in app master so we don't leak non-daemon threads


make sure to start the container manager


ugrading to yarn 2.2


Diffs (updated)
-----

  build.gradle 1482ea960bb06d6b06a7dad08cc397e693c7d098 
  gradle.properties ed6390bf8c87bf07ef4da7c79eba95045c69efdc 
  gradle/dependency-versions.gradle 5f3fb326fbeecda85012c495ad41706287c92158 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala b2b529e3fab0762693a9c3d44f1b206fde92b8cb 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 7f830f21f286b72e2fcc0897f2bef22239f4dc02 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterLifecycle.scala 95a6f05a74cecae10a4af69033f813f5f6f21990 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala ce3fcc32a8d1743dcc0f09817601b84d7bb3a2c5 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterTaskManager.scala 1a13ee5ed945d399b1cc6fca1883ae937a305f7e 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnAppMaster.scala 14e3865afeb62b7bf2b6a9c63c294540e8b18d02 
  samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala bde38e170bfb8d30119134b9ebc20fa04c23e541 
  samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala cbd7c1eefa081b426086e15545cdb1a5d99d8a83 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterLifecycle.scala 8bf48eb5df77cc95a0a8cdd33f45680113847c6f 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterTaskManager.scala c9f70291ba436d4833a2639e8845dbca4691ff9b 
  samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestYarnAppMaster.scala 0040648b21ebd094563cac566550c3a2dd4b24bc 

Diff: https://reviews.apache.org/r/14767/diff/


Testing
-------


Thanks,

Chris Riccomini