svn commit: r1716765 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java

[ad...@apache.org]

Author: adelmelle
Date: Thu Nov 26 20:41:24 2015
New Revision: 1716765

URL: http://svn.apache.org/viewvc?rev=1716765&view=rev
Log:
Minor fixups: remove redundant null check, remove redundant initial assignment + start of javadoc fixups

Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java?rev=1716765&r1=1716764&r2=1716765&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/FloatContentLayoutManager.java Thu Nov 26 20:41:24 2015
@@ -38,30 +38,40 @@ public class FloatContentLayoutManager e
     private int side;
     private int yOffset;
 
+    /**
+     * {@asf.todo - Add info}
+     *
+     * @param node the {@link Float} associated with this instance
+     */
     public FloatContentLayoutManager(Float node) {
         super(node);
         generatesReferenceArea = true;
         side = node.getFloat();
     }
 
+    @Override
     public Keep getKeepTogether() {
         return getParentKeepTogether();
     }
 
+    @Override
     public Keep getKeepWithNext() {
         return Keep.KEEP_AUTO;
     }
 
+    @Override
     public Keep getKeepWithPrevious() {
         return Keep.KEEP_ALWAYS;
     }
 
+    @Override
     public void addAreas(PositionIterator parentIter, LayoutContext layoutContext) {
         floatContentArea = new SideFloat();
         AreaAdditionUtil.addAreas(this, parentIter, layoutContext);
         flush();
     }
 
+    @Override
     public void addChildArea(Area childArea) {
         floatContentArea.addChildArea(childArea);
         floatContentArea.setBPD(childArea.getAllocBPD());
@@ -89,6 +99,14 @@ public class FloatContentLayoutManager e
         }
     }
 
+    /**
+     * {@asf.todo - Add info}
+     *
+     * @param elemenList
+     * @param startIndex
+     * @param endIndex
+     * @return
+     */
     public static List<FloatContentLayoutManager> checkForFloats(List<ListElement> elemenList,
             int startIndex, int endIndex) {
         ListIterator<ListElement> iter = elemenList.listIterator(startIndex);
@@ -108,10 +126,16 @@ public class FloatContentLayoutManager e
         }
     }
 
+    @Override
     protected CommonBorderPaddingBackground getCommonBorderPaddingBackground() {
         return null;
     }
 
+    /**
+     * {@asf.todo - Add info}
+     *
+     * @param layoutContext
+     */
     public void processAreas(LayoutContext layoutContext) {
         if (getParent() instanceof FloatLayoutManager) {
             FloatLayoutManager flm = (FloatLayoutManager) getParent();
@@ -119,23 +143,27 @@ public class FloatContentLayoutManager e
         }
     }
 
+    /**
+     * @return the height of the float content area
+     */
     public int getFloatHeight() {
         return floatContentArea.getAllocBPD();
     }
 
+    /**
+     * @return the y-offset of the float content
+     */
     public int getFloatYOffset() {
         return yOffset;
     }
 
     private int getStartIndent() {
-        int startIndent = 0;
+        int startIndent;
         LayoutManager lm = getParent();
         while (!(lm instanceof BlockLayoutManager)) {
             lm = lm.getParent();
         }
-        if (lm != null) {
-            startIndent = ((BlockLayoutManager) lm).startIndent;
-        }
+        startIndent = ((BlockLayoutManager) lm).startIndent;
         return startIndent;
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org