You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/15 04:38:36 UTC

[GitHub] [spark] itholic opened a new pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

itholic opened a new pull request #34905:
URL: https://github.com/apache/spark/pull/34905


   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This is follow-up for https://github.com/apache/spark/pull/34853, to mention the behavior changes to migration guide, too.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   We should mention the behavior change to the migration guide, although it's bug fix.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   The explanation is added to the migration guide.
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   Manually built docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994303711


   **[Test build #146213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146213/testReport)** for PR 34905 at commit [`c90d819`](https://github.com/apache/spark/commit/c90d8190f90320004a5ef2093470ea8e315fd5ab).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #34905:
URL: https://github.com/apache/spark/pull/34905#discussion_r769283078



##########
File path: docs/sql-migration-guide.md
##########
@@ -52,6 +52,8 @@ license: |
 
   - Since Spark 3.3, the `strfmt` in `format_string(strfmt, obj, ...)` and `printf(strfmt, obj, ...)` will no longer support to use "0$" to specify the first argument, the first argument should always reference by "1$" when use argument index to indicating the position of the argument in the argument list.
 
+  - Since Spark 3.3, nulls are written as empty strings in CSV data source by default. In Spark 3.2 or earlier, nulls were written as empty strings as quoted empty strings, `""`. To restore the previous behavior, set `nullValue` to `""`.

Review comment:
       > To restore the previous behavior, set `nullValue` to `""`
   
   Actually, it is correct but if an user sets the option stupidly as recommended:
   ```scala
   scala> val df = Seq("abc", null, "def").toDF()
   df: org.apache.spark.sql.DataFrame = [value: string]
   
   scala> df.repartition(1).write.option("nullValue", "").mode("overwrite").csv("/Users/maximgekk/tmp/csv3")
   ``` 
   ```
   $ csv3 cat ./part-00000-5830ac7c-3653-41ec-a2f7-c56934ef56d9-c000.csv
   abc
   def
   ```
   but:
   ```
   scala> df.repartition(1).write.option("nullValue", "\"\"").mode("overwrite").csv("/Users/maximgekk/tmp/csv4")
   ```
   ```
   $ csv4 cat ./part-00000-6a5b0628-8924-4300-9699-89f4df903db9-c000.csv
   abc
   ""
   def
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994308805


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146213/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994392972


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994369574


   **[Test build #146217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146217/testReport)** for PR 34905 at commit [`253afac`](https://github.com/apache/spark/commit/253afac4104ba649b44d0e1fc4fbb949d7977439).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34905:
URL: https://github.com/apache/spark/pull/34905


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994325780


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994350154


   **[Test build #146217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146217/testReport)** for PR 34905 at commit [`253afac`](https://github.com/apache/spark/commit/253afac4104ba649b44d0e1fc4fbb949d7977439).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994401426


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50691/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994410663


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994467119


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50691/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34905:
URL: https://github.com/apache/spark/pull/34905#discussion_r769305397



##########
File path: docs/sql-migration-guide.md
##########
@@ -52,6 +52,8 @@ license: |
 
   - Since Spark 3.3, the `strfmt` in `format_string(strfmt, obj, ...)` and `printf(strfmt, obj, ...)` will no longer support to use "0$" to specify the first argument, the first argument should always reference by "1$" when use argument index to indicating the position of the argument in the argument list.
 
+  - Since Spark 3.3, nulls are written as empty strings in CSV data source by default. In Spark 3.2 or earlier, nulls were written as empty strings as quoted empty strings, `""`. To restore the previous behavior, set `nullValue` to `""`.

Review comment:
       Let me just merge as is ... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994369862


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146217/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994410663


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994303711


   **[Test build #146213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146213/testReport)** for PR 34905 at commit [`c90d819`](https://github.com/apache/spark/commit/c90d8190f90320004a5ef2093470ea8e315fd5ab).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #34905:
URL: https://github.com/apache/spark/pull/34905#discussion_r769283078



##########
File path: docs/sql-migration-guide.md
##########
@@ -52,6 +52,8 @@ license: |
 
   - Since Spark 3.3, the `strfmt` in `format_string(strfmt, obj, ...)` and `printf(strfmt, obj, ...)` will no longer support to use "0$" to specify the first argument, the first argument should always reference by "1$" when use argument index to indicating the position of the argument in the argument list.
 
+  - Since Spark 3.3, nulls are written as empty strings in CSV data source by default. In Spark 3.2 or earlier, nulls were written as empty strings as quoted empty strings, `""`. To restore the previous behavior, set `nullValue` to `""`.

Review comment:
       > To restore the previous behavior, set `nullValue` to `""`
   
   Actually, it is correct but if an user set the option stupidly as recommended:
   ```scala
   scala> val df = Seq("abc", null, "def").toDF()
   df: org.apache.spark.sql.DataFrame = [value: string]
   
   scala> df.repartition(1).write.option("nullValue", "").mode("overwrite").csv("/Users/maximgekk/tmp/csv3")
   ``` 
   ```
   $ csv3 cat ./part-00000-5830ac7c-3653-41ec-a2f7-c56934ef56d9-c000.csv
   abc
   def
   ```
   but:
   ```
   scala> df.repartition(1).write.option("nullValue", "\"\"").mode("overwrite").csv("/Users/maximgekk/tmp/csv4")
   ```
   ```
   $ csv4 cat ./part-00000-6a5b0628-8924-4300-9699-89f4df903db9-c000.csv
   abc
   ""
   def
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994308805


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146213/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994378826


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50687/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][FOLLOWUP][SQL] Update migration guide for null values saving

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994308625


   **[Test build #146213 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146213/testReport)** for PR 34905 at commit [`c90d819`](https://github.com/apache/spark/commit/c90d8190f90320004a5ef2093470ea8e315fd5ab).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994369862


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146217/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994350154


   **[Test build #146217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146217/testReport)** for PR 34905 at commit [`253afac`](https://github.com/apache/spark/commit/253afac4104ba649b44d0e1fc4fbb949d7977439).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994481802


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50691/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34905: [SPARK-37575][SQL][FOLLOWUP] Update migration guide for null values saving in CSV data source

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34905:
URL: https://github.com/apache/spark/pull/34905#issuecomment-994481802


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50691/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org