You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by bjhargrave <gi...@git.apache.org> on 2016/06/08 19:47:39 UTC
[GitHub] incubator-quarks pull request #131: [QUARKS-139] Alternative gradle build
GitHub user bjhargrave opened a pull request:
https://github.com/apache/incubator-quarks/pull/131
[QUARKS-139] Alternative gradle build
Here is another go at a gradle build replacement for quarks.
This build has minimal `build.gradle` files in each project and concentrates the build logic in the root project `build.gradle` file.
This build tries to use the standard gradle way of doing things. Output is placed in the standard gradle places. e.g. `build/libs` for generated jar file. Inter-project dependencies are expressed using `project(':api:topology')` form. External jars are referenced using mavenCentral to avoid the need to place binaries in the build.
The build completes and tests pass running `./gradlew build`.
This only builds the projects with Java 8. More work is of course needed to complete the build in gradle such as the Java 7 and Android part as well as any packaging steps to package the generated jars into some distribution shape.
Eventually, I want to apply the `biz.aQute.bnd.builder` plugin to generate OSGi metadata for each generated jar to allow the jars to be used in OSGi runtimes such as Eclipse Kura.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjhargrave/incubator-quarks gradle-build
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quarks/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit d5cc0cfb85343558b45c071a6ce5386c1466833b
Author: BJ Hargrave <ha...@us.ibm.com>
Date: 2016-06-06T19:53:55Z
gradle: .gitignores for gradle build
commit 9574ab0891d452bf1c91b54048ae2e316edd7f6f
Author: BJ Hargrave <ha...@us.ibm.com>
Date: 2016-06-06T19:54:16Z
gradle: Add gradle wrapper
commit b95599986437898255628aa811b4d23d8aa65cd5
Author: BJ Hargrave <ha...@us.ibm.com>
Date: 2016-06-08T18:16:21Z
gradle: Initial Java 8 build
commit c52ecf7ca8ec1f31ed99c4e944f02185f56833c4
Author: BJ Hargrave <ha...@us.ibm.com>
Date: 2016-06-08T19:32:29Z
gradle: Update ServerUtil to find webapps folder in gradle build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66441406
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -45,31 +53,35 @@ private String getPath() {
* @return a File object
*/
private File getTopDirFilePath() {
+ String topDirProp = System.getProperty("top.dir.file.path");
--- End diff --
That is probably a good idea. Do we want to wait until a new name is settled upon? Or just plan to change the name from quarks later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66439987
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -19,10 +19,18 @@ Licensed to the Apache Software Foundation (ASF) under one
package quarks.console.server;
+import java.io.IOException;
import java.io.File;
import java.io.FilenameFilter;
import java.net.URL;
+import java.nio.file.Files;
--- End diff --
Good catch. Thanks. I amended the commit to remove the old import.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66338884
--- Diff: build.gradle ---
@@ -0,0 +1,96 @@
+/* Configure root project */
+ext.commithash = {
+ try {
+ return "git rev-parse --short HEAD".execute().text.trim()
+ } catch (Exception e) {
+ return ''
+ }
+}()
+def now = new Date()
+ext.DSTAMP = String.format('%tY%<tm%<td', now)
+ext.TSTAMP = String.format('%tH%<tM', now)
+ext.ext_classpath = ['com.google.code.gson:gson:2.2.4',
+ 'org.slf4j:slf4j-api:1.7.12',
+ 'io.dropwizard.metrics:metrics-core:3.1.2']
+
+/* Configure subprojects */
+subprojects {
+ repositories {
+ mavenCentral()
+ maven {
+ url 'https://repo.eclipse.org/content/repositories/paho-snapshots/'
+ }
+ }
+
+ plugins.apply 'java'
+ plugins.apply 'jacoco'
+
+ archivesBaseName = "${rootProject.name}${project.path.replace(':','.')}"
+ version = quarks_version
+
+ jacoco {
+ toolVersion = '0.7.5.201505241946'
+ }
+
+ dependencies {
+ testCompile 'junit:junit:4.10'
+ testRuntime 'org.slf4j:slf4j-jdk14:1.7.12'
+ }
+
+ ext.addCompileTestDependencies = { String... deps ->
+ deps.each { dep ->
+ dependencies {
+ testCompile project(dep).sourceSets.test.output
+ }
+ compileTestJava {
+ dependsOn "${dep}:compileTestJava"
+ }
+ }
+ }
+
+ sourceCompatibility = '1.8'
+ targetCompatibility = '1.8'
+ def compileOptions = {
+ options.debugOptions.debugLevel = 'source,lines,vars'
+ options.verbose = logger.isDebugEnabled()
+ options.listFiles = logger.isInfoEnabled()
+ options.deprecation = true
+ options.encoding = 'UTF-8'
+ }
+ compileJava {
+ configure compileOptions
+ }
+ compileTestJava {
+ configure compileOptions
+ }
+
+ test {
+ include '**/*Test.class'
+ systemProperty 'top.dir.file.path', rootProject.projectDir
+ testLogging {
+ exceptionFormat 'full'
+ }
+ }
+
+ ext.jarOptions = {
+ manifest {
+ attributes(
+ 'Implementation-Title': "${-> baseName}",
+ 'Implementation-Vendor': 'quarks-edge@github.com',
--- End diff --
Changed to Apache Software Foundation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66440962
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -45,31 +53,35 @@ private String getPath() {
* @return a File object
*/
private File getTopDirFilePath() {
+ String topDirProp = System.getProperty("top.dir.file.path");
--- End diff --
~nit: can we use a property name that's scoped by "quarks"? It seems this new property is required/used only to make things work in the build/test context. If that's true then perhaps also have the name capture that: "quarks.test. ..."?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [QUARKS-139] Alternative gradle build
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66334945
--- Diff: build.gradle ---
@@ -0,0 +1,96 @@
+/* Configure root project */
+ext.commithash = {
+ try {
+ return "git rev-parse --short HEAD".execute().text.trim()
+ } catch (Exception e) {
+ return ''
+ }
+}()
+def now = new Date()
+ext.DSTAMP = String.format('%tY%<tm%<td', now)
+ext.TSTAMP = String.format('%tH%<tM', now)
+ext.ext_classpath = ['com.google.code.gson:gson:2.2.4',
+ 'org.slf4j:slf4j-api:1.7.12',
+ 'io.dropwizard.metrics:metrics-core:3.1.2']
+
+/* Configure subprojects */
+subprojects {
+ repositories {
+ mavenCentral()
+ maven {
+ url 'https://repo.eclipse.org/content/repositories/paho-snapshots/'
+ }
+ }
+
+ plugins.apply 'java'
+ plugins.apply 'jacoco'
+
+ archivesBaseName = "${rootProject.name}${project.path.replace(':','.')}"
+ version = quarks_version
+
+ jacoco {
+ toolVersion = '0.7.5.201505241946'
+ }
+
+ dependencies {
+ testCompile 'junit:junit:4.10'
+ testRuntime 'org.slf4j:slf4j-jdk14:1.7.12'
+ }
+
+ ext.addCompileTestDependencies = { String... deps ->
+ deps.each { dep ->
+ dependencies {
+ testCompile project(dep).sourceSets.test.output
+ }
+ compileTestJava {
+ dependsOn "${dep}:compileTestJava"
+ }
+ }
+ }
+
+ sourceCompatibility = '1.8'
+ targetCompatibility = '1.8'
+ def compileOptions = {
+ options.debugOptions.debugLevel = 'source,lines,vars'
+ options.verbose = logger.isDebugEnabled()
+ options.listFiles = logger.isInfoEnabled()
+ options.deprecation = true
+ options.encoding = 'UTF-8'
+ }
+ compileJava {
+ configure compileOptions
+ }
+ compileTestJava {
+ configure compileOptions
+ }
+
+ test {
+ include '**/*Test.class'
+ systemProperty 'top.dir.file.path', rootProject.projectDir
+ testLogging {
+ exceptionFormat 'full'
+ }
+ }
+
+ ext.jarOptions = {
+ manifest {
+ attributes(
+ 'Implementation-Title': "${-> baseName}",
+ 'Implementation-Vendor': 'quarks-edge@github.com',
--- End diff --
Yeah, I just got that from [master](https://github.com/apache/incubator-quarks/blob/master/common-build.xml#L169). I'll amend the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66438063
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -19,10 +19,18 @@ Licensed to the Apache Software Foundation (ASF) under one
package quarks.console.server;
+import java.io.IOException;
import java.io.File;
import java.io.FilenameFilter;
import java.net.URL;
+import java.nio.file.Files;
--- End diff --
pls remove above FilenameFilter import as it's now no longer used and causes compile warning in Eclipse.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66337307
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -45,31 +53,35 @@ private String getPath() {
* @return a File object
*/
private File getTopDirFilePath() {
+ String topDirProp = System.getProperty("top.dir.file.path");
+ if (topDirProp != null) {
+ return new File(topDirProp);
+ }
File jarFile = new File(getPath());
return jarFile.getParentFile().getParentFile().getParentFile();
}
- // create new filename filter
- FilenameFilter fileNameFilter = new FilenameFilter() {
-
- @Override
- public boolean accept(File dir, String name) {
- if (name.equals("webapps")) {
- return true;
- }
- else {
- return false;
- }
- }
- };
/**
* Returns the File object representing the "webapps" directory
* @return a File object or null if the "webapps" directory is not found
*/
private File getWarFilePath() {
- File[] foundFiles = getTopDirFilePath().listFiles(fileNameFilter);
- if (foundFiles.length == 1) {
- return foundFiles[0];
+ List<File> foundFiles = new ArrayList<>();
--- End diff --
It had to change because this code is badly dependent upon the structure of the build. It assumed that the jars all sit in target/java... getTopDirFilePath assume ../../.. from the jar to find the webapp. Since the gradle build uses normal gradle output locations, the webapp folder is elsewhere. c52ecf7ca8ec1f31ed99c4e944f02185f56833c4 is the commit to be more flexible in locating the webapps folder in the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by bjhargrave <gi...@git.apache.org>.
Github user bjhargrave commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66411282
--- Diff: console/servlets/build.gradle ---
@@ -0,0 +1,23 @@
+distsDirName = 'webapps'
+
+plugins.apply 'war'
+
+dependencies {
+ providedCompile 'javax.servlet:javax.servlet-api:3.1.0'
+ providedCompile project(':utils:streamscope')
+ providedCompile ext_classpath
+}
+
+war {
--- End diff --
Yes, all the tests passed for me. The change in 5a5014f is needed to find the console.war file built in the gradle build. Make sure you have the complete branch checked out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [QUARKS-139] Alternative gradle build
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66333939
--- Diff: build.gradle ---
@@ -0,0 +1,96 @@
+/* Configure root project */
+ext.commithash = {
+ try {
+ return "git rev-parse --short HEAD".execute().text.trim()
+ } catch (Exception e) {
+ return ''
+ }
+}()
+def now = new Date()
+ext.DSTAMP = String.format('%tY%<tm%<td', now)
+ext.TSTAMP = String.format('%tH%<tM', now)
+ext.ext_classpath = ['com.google.code.gson:gson:2.2.4',
+ 'org.slf4j:slf4j-api:1.7.12',
+ 'io.dropwizard.metrics:metrics-core:3.1.2']
+
+/* Configure subprojects */
+subprojects {
+ repositories {
+ mavenCentral()
+ maven {
+ url 'https://repo.eclipse.org/content/repositories/paho-snapshots/'
+ }
+ }
+
+ plugins.apply 'java'
+ plugins.apply 'jacoco'
+
+ archivesBaseName = "${rootProject.name}${project.path.replace(':','.')}"
+ version = quarks_version
+
+ jacoco {
+ toolVersion = '0.7.5.201505241946'
+ }
+
+ dependencies {
+ testCompile 'junit:junit:4.10'
+ testRuntime 'org.slf4j:slf4j-jdk14:1.7.12'
+ }
+
+ ext.addCompileTestDependencies = { String... deps ->
+ deps.each { dep ->
+ dependencies {
+ testCompile project(dep).sourceSets.test.output
+ }
+ compileTestJava {
+ dependsOn "${dep}:compileTestJava"
+ }
+ }
+ }
+
+ sourceCompatibility = '1.8'
+ targetCompatibility = '1.8'
+ def compileOptions = {
+ options.debugOptions.debugLevel = 'source,lines,vars'
+ options.verbose = logger.isDebugEnabled()
+ options.listFiles = logger.isInfoEnabled()
+ options.deprecation = true
+ options.encoding = 'UTF-8'
+ }
+ compileJava {
+ configure compileOptions
+ }
+ compileTestJava {
+ configure compileOptions
+ }
+
+ test {
+ include '**/*Test.class'
+ systemProperty 'top.dir.file.path', rootProject.projectDir
+ testLogging {
+ exceptionFormat 'full'
+ }
+ }
+
+ ext.jarOptions = {
+ manifest {
+ attributes(
+ 'Implementation-Title': "${-> baseName}",
+ 'Implementation-Vendor': 'quarks-edge@github.com',
--- End diff --
Should be apache/incubator-quarks@github.com or such I think? quarks-edge is the decomissioned pre-ASF project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66442548
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -45,31 +53,35 @@ private String getPath() {
* @return a File object
*/
private File getTopDirFilePath() {
+ String topDirProp = System.getProperty("top.dir.file.path");
--- End diff --
I think now is best. It won't make converting any harder / will just get adjusted when we handle all other occurrences.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by ddebrunner <gi...@git.apache.org>.
Github user ddebrunner commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66336256
--- Diff: console/server/src/main/java/quarks/console/server/ServerUtil.java ---
@@ -45,31 +53,35 @@ private String getPath() {
* @return a File object
*/
private File getTopDirFilePath() {
+ String topDirProp = System.getProperty("top.dir.file.path");
+ if (topDirProp != null) {
+ return new File(topDirProp);
+ }
File jarFile = new File(getPath());
return jarFile.getParentFile().getParentFile().getParentFile();
}
- // create new filename filter
- FilenameFilter fileNameFilter = new FilenameFilter() {
-
- @Override
- public boolean accept(File dir, String name) {
- if (name.equals("webapps")) {
- return true;
- }
- else {
- return false;
- }
- }
- };
/**
* Returns the File object representing the "webapps" directory
* @return a File object or null if the "webapps" directory is not found
*/
private File getWarFilePath() {
- File[] foundFiles = getTopDirFilePath().listFiles(fileNameFilter);
- if (foundFiles.length == 1) {
- return foundFiles[0];
+ List<File> foundFiles = new ArrayList<>();
--- End diff --
Seems like this is a merge error, I'm assuming this file should not change because of gradle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by Cazen <gi...@git.apache.org>.
Github user Cazen commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66384667
--- Diff: console/servlets/build.gradle ---
@@ -0,0 +1,23 @@
+distsDirName = 'webapps'
+
+plugins.apply 'war'
+
+dependencies {
+ providedCompile 'javax.servlet:javax.servlet-api:3.1.0'
+ providedCompile project(':utils:streamscope')
+ providedCompile ext_classpath
+}
+
+war {
--- End diff --
Does all the test case passed? In my case, build failed due to console.war location
Could you tell me if there is something forgotten setting that I missed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by ddebrunner <gi...@git.apache.org>.
Github user ddebrunner commented on a diff in the pull request:
https://github.com/apache/incubator-quarks/pull/131#discussion_r66335673
--- Diff: build.gradle ---
@@ -0,0 +1,96 @@
+/* Configure root project */
+ext.commithash = {
+ try {
+ return "git rev-parse --short HEAD".execute().text.trim()
+ } catch (Exception e) {
+ return ''
+ }
+}()
+def now = new Date()
+ext.DSTAMP = String.format('%tY%<tm%<td', now)
+ext.TSTAMP = String.format('%tH%<tM', now)
+ext.ext_classpath = ['com.google.code.gson:gson:2.2.4',
+ 'org.slf4j:slf4j-api:1.7.12',
+ 'io.dropwizard.metrics:metrics-core:3.1.2']
+
+/* Configure subprojects */
+subprojects {
+ repositories {
+ mavenCentral()
+ maven {
+ url 'https://repo.eclipse.org/content/repositories/paho-snapshots/'
+ }
+ }
+
+ plugins.apply 'java'
+ plugins.apply 'jacoco'
+
+ archivesBaseName = "${rootProject.name}${project.path.replace(':','.')}"
+ version = quarks_version
+
+ jacoco {
+ toolVersion = '0.7.5.201505241946'
+ }
+
+ dependencies {
+ testCompile 'junit:junit:4.10'
+ testRuntime 'org.slf4j:slf4j-jdk14:1.7.12'
+ }
+
+ ext.addCompileTestDependencies = { String... deps ->
+ deps.each { dep ->
+ dependencies {
+ testCompile project(dep).sourceSets.test.output
+ }
+ compileTestJava {
+ dependsOn "${dep}:compileTestJava"
+ }
+ }
+ }
+
+ sourceCompatibility = '1.8'
+ targetCompatibility = '1.8'
+ def compileOptions = {
+ options.debugOptions.debugLevel = 'source,lines,vars'
+ options.verbose = logger.isDebugEnabled()
+ options.listFiles = logger.isInfoEnabled()
+ options.deprecation = true
+ options.encoding = 'UTF-8'
+ }
+ compileJava {
+ configure compileOptions
+ }
+ compileTestJava {
+ configure compileOptions
+ }
+
+ test {
+ include '**/*Test.class'
+ systemProperty 'top.dir.file.path', rootProject.projectDir
+ testLogging {
+ exceptionFormat 'full'
+ }
+ }
+
+ ext.jarOptions = {
+ manifest {
+ attributes(
+ 'Implementation-Title': "${-> baseName}",
+ 'Implementation-Vendor': 'quarks-edge@github.com',
--- End diff --
Should be the Apache Software Foundation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quarks pull request #131: [WIP][QUARKS-139] Alternative gradle bui...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quarks/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---