You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/17 20:06:48 UTC

[GitHub] [kafka] rhauch commented on pull request #10337: KAFKA-12380: Executor in Connect's Worker is not shut down when the worker is

rhauch commented on pull request #10337:
URL: https://github.com/apache/kafka/pull/10337#issuecomment-801398429


   Also, there are [24 failed unit tests on the different jobs](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10337/4/testReport/junit/org.apache.kafka.connect.runtime/?cloudbees-analytics-link=scm-reporting%2Ftests%2Ffailed), of the form:
   ```
   java.lang.AssertionError: 
     Unexpected method call ExecutorService.shutdownNow():
   ```
   Please make sure you run the tests locally. The `WorkerTest` mocks the executor service, and thus it is checking that only the methods specified in the tests are called, so `shutdownNow()` is unexpected. You'll need to add that call as expected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org