You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Jason Pell (JIRA)" <ji...@apache.org> on 2012/10/08 04:06:02 UTC

[jira] [Created] (CXF-4547) WsPolicyFeature with externalAttachment puts the policies under Service rather than under wsdl definitions

Jason Pell created CXF-4547:
-------------------------------

             Summary: WsPolicyFeature with externalAttachment puts the policies under Service rather than under wsdl definitions
                 Key: CXF-4547
                 URL: https://issues.apache.org/jira/browse/CXF-4547
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
    Affects Versions: 2.6.2
            Reporter: Jason Pell
             Fix For: 2.6.3, 2.7.0


When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) WsPolicyFeature externalAttachment and wsdl update fixes and enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Fix Version/s:     (was: 2.6.3)
                       (was: 2.7.0)
    
> WsPolicyFeature externalAttachment and wsdl update fixes and enhancements
> -------------------------------------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  
> This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.
> I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  
> Also update the wsp namespace to the generic http://www.w3.org/ns/ws-polic

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) WsPolicyFeature externalAttachment and wsdl update fixes and enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Description: 
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

Also update the wsp namespace to the generic http://www.w3.org/ns/ws-polic


  was:
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

    
> WsPolicyFeature externalAttachment and wsdl update fixes and enhancements
> -------------------------------------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2
>            Reporter: Jason Pell
>             Fix For: 2.6.3, 2.7.0
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  
> This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.
> I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  
> Also update the wsp namespace to the generic http://www.w3.org/ns/ws-polic

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) WsPolicyFeature externalAttachment and wsdl update fixes and enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Description: 
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

  was:
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

        Summary: WsPolicyFeature externalAttachment and wsdl update fixes and enhancements  (was: WsPolicyFeature with externalAttachment puts the policies under Service rather than under wsdl definitions)
    
> WsPolicyFeature externalAttachment and wsdl update fixes and enhancements
> -------------------------------------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2
>            Reporter: Jason Pell
>             Fix For: 2.6.3, 2.7.0
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  
> This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.
> I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-4547.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.7.1
         Assignee: Daniel Kulp
    
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>            Assignee: Daniel Kulp
>             Fix For: 2.7.1
>
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) WsPolicyFeature externalAttachment and wsdl update fixes and enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Attachment: patch.txt

This patch updates the Ws-Policy namespaces to the default.

Ensures that the generated policy elements include a Id with a namespace prefix.

Added support for attaching policy references to messages instead of just operations.

Added test cases for all of these.
                
> WsPolicyFeature externalAttachment and wsdl update fixes and enhancements
> -------------------------------------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2
>            Reporter: Jason Pell
>             Fix For: 2.6.3, 2.7.0
>
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  
> This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.
> I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  
> Also update the wsp namespace to the generic http://www.w3.org/ns/ws-polic

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Attachment:     (was: patch.txt)
    
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472075#comment-13472075 ] 

Jason Pell edited comment on CXF-4547 at 10/9/12 4:37 AM:
----------------------------------------------------------

Updated patch which uses the external policy ws-policy namespace for the policy reference instead of a hard coded namespace that might be different.

Updated the test case to test this scenario.

This patch is now considered complete awaiting review and hopefully inclusion into 2.7.1 / 2.6.4



                
      was (Author: pellcorp):
    Updated patch which uses the external policy ws-securitypolicy namespace for the policy reference instead of a hard coded namespace that might be different.

Updated the test case to test this scenario.

This patch is now considered complete awaiting review and hopefully inclusion into 2.7.1 / 2.6.4



                  
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471971#comment-13471971 ] 

Jason Pell commented on CXF-4547:
---------------------------------

I am glad this patch did not make it into the release.  I have noticed some subtle problems with it and need to spend some time trying to understand them before I can offer another patch which fixes them.  The first problem I noticed is that I am getting policy violations when this patch is enabled that I do not get when its disabled.  I am not sure why.
                
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Description: 
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.

i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

  was:
When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>

I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener.  

This is a simple fix to ServiceModelPolicyUpdater which I will submit along with test cases for same.

I would also like to the service model policy updater to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

Also update the wsp namespace to the generic http://www.w3.org/ns/ws-polic


        Summary: java first externalAttachment wsdl enhancements  (was: WsPolicyFeature externalAttachment and wsdl update fixes and enhancements)
    
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Attachment: patch.txt

Updated patch which uses the external policy ws-securitypolicy namespace for the policy reference instead of a hard coded namespace that might be different.

Updated the test case to test this scenario.

This patch is now considered complete awaiting review and hopefully inclusion into 2.7.1 / 2.6.4



                
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Pell updated CXF-4547:
----------------------------

    Affects Version/s: 2.7.0
                       2.6.3
    
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CXF-4547) java first externalAttachment wsdl enhancements

Posted by "Jason Pell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474066#comment-13474066 ] 

Jason Pell commented on CXF-4547:
---------------------------------

was wondering if I could get some feedback on this patch. Happy to do additional work for it to be acceptable. 

I am blocked on this as I need the changes in my project and do not want to maintain a local fork of cxf, but happy to depend on a 2.7.1-SNAPSHOT for a few months.
                
> java first externalAttachment wsdl enhancements
> -----------------------------------------------
>
>                 Key: CXF-4547
>                 URL: https://issues.apache.org/jira/browse/CXF-4547
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.2, 2.6.3, 2.7.0
>            Reporter: Jason Pell
>         Attachments: patch.txt
>
>
> When I define a <p:externalAttachment location="classpath:SslWithUsernamePasswordToken.xml"/>
> I expect to see the associated Policies directly underneath the wsdl:definitions, just like how PolicyAnnotationListener does it.
> i would also expect the generated wsdl to correctly reflect if I am associating a policy with just a message rather than an operation as a whole.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira