[PATCH] Maven (huge)

[Stephane Bailliez <sb...@apache.org>]

Patch for Maven repository. Sorry for the zip but it's a huge patch (284KB)
and I did not feel like sending 100 patches (nor I do think it's fun to
commit 100 patches)

Things that have changed:
- Added a Maven Apache copyright to most files.
- Changed the copyright date from 2001 to 2002 for existing one.
- Removed weird double EOL in some files (jrcs)
- Removed unused import for a couple of files and code layout as well.
- Added braces for all if/else/while/for that were missing it (311 hits so
far excluding parser code)
- fancy javadoc fix in a couple of places, no big deal.

Good luck for the person that will review the 284KB patch :o)

ps: I recommend choosing some coding guidelines for Maven ASAP so that we
can safely refactor/clean up everything with a single coding style. Due to
legacy code there are 3 coding styles in it. I would rather prefer we choose
the Jakarta one (ie Sun) and that we stick to it otherwise it is painful to
reconfigure an editor to enforce a particular convention each time we move
from a project to another. (Sorry Jason, I know you use the Allman style in
Turbine, but you're free to decide whether we should use this one or not for
Maven. Just shout out loud ;-).

Cheers,

Stephane

Re: [PATCH] Maven (huge)

[Daniel Rall <dl...@finemaltcoding.com>]

James Taylor <jt...@4lane.com> writes:

>> ps: I recommend choosing some coding guidelines for Maven ASAP so that we
>> can safely refactor/clean up everything with a single coding style. Due to
>> legacy code there are 3 coding styles in it. I would rather prefer we choose
>> the Jakarta one (ie Sun) and that we stick to it otherwise it is painful to
>> reconfigure an editor to enforce a particular convention each time we move
>> from a project to another. (Sorry Jason, I know you use the Allman style in
>> Turbine, but you're free to decide whether we should use this one or not for
>> Maven. Just shout out loud ;-).
>
> +1 for standardizing on the style used by all other projects in turbine,
> rather than the evil whitespace reducing unreadable sun style. =]
>
> it is jakarta-turbine-maven after all right?
>               ^^^^^^^

+1, what James said.  ;-)

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [PATCH] Maven (huge)

[James Taylor <jt...@4lane.com>]

> ps: I recommend choosing some coding guidelines for Maven ASAP so that we
> can safely refactor/clean up everything with a single coding style. Due to
> legacy code there are 3 coding styles in it. I would rather prefer we choose
> the Jakarta one (ie Sun) and that we stick to it otherwise it is painful to
> reconfigure an editor to enforce a particular convention each time we move
> from a project to another. (Sorry Jason, I know you use the Allman style in
> Turbine, but you're free to decide whether we should use this one or not for
> Maven. Just shout out loud ;-).

+1 for standardizing on the style used by all other projects in turbine,
rather than the evil whitespace reducing unreadable sun style. =]

it is jakarta-turbine-maven after all right?
              ^^^^^^^

-- jt


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>