You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Michael Dick (JIRA)" <ji...@apache.org> on 2009/01/29 21:06:01 UTC

[jira] Created: (OPENJPA-881) Enable connection pooling for testcases.

Enable connection pooling for testcases. 
-----------------------------------------

                 Key: OPENJPA-881
                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
             Project: OpenJPA
          Issue Type: Improvement
    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
            Reporter: Michael Dick
            Assignee: Michael Dick


Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670279#action_12670279 ] 

Milosz Tylenda commented on OPENJPA-881:
----------------------------------------

No. I run the test suite with the settings mentioned earlier quite often on Linux and sometimes on Windows and can't remember any problems. However, I ran into problems (too many connections, etc.) when I probably didn't specify the eviction properties.

I haven't tried the latest snapshots though.


> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668911#action_12668911 ] 

Michael Dick commented on OPENJPA-881:
--------------------------------------

Hi Milosz, 

I remember the conversation. All I really wanted to do in this issue is set MaxIdle >=0 so that we maintain at least one connection. Along the way I split out the settings we've used in the past into their own properties. 

I've never messed around with the eviction times but they're easy enough to specify via dbcp.args or I can split them into their own properties too if you'd prefer that. 

> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668836#action_12668836 ] 

Milosz Tylenda commented on OPENJPA-881:
----------------------------------------

Mike, we have once discussed it here [1], maybe it's worth re-reading. I run the test suite on various databases and found the below settings quite useful on my system (all databases and OpenJPA are co-located):

<dbcp.args>MaxActive=100,MaxIdle=10,MaxWait=10000,timeBetweenEvictionRunsMillis=2000,minEvictableIdleTimeMillis=1000</dbcp.args>

[1] http://n2.nabble.com/Test-suite-slow-on-DB2-td1115993.html#a1115993


> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670110#action_12670110 ] 

Michael Dick commented on OPENJPA-881:
--------------------------------------

I went ahead and tried adding the properties and ran into an error with commons-dbcp 1.2.1. Upgrading to 1.2.2 resolved the issue. Did you run into the same or similar problems Milosz? 

> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dick closed OPENJPA-881.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0
                   1.3.0
                   1.2.1
                   1.0.4

> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>             Fix For: 1.0.4, 1.2.1, 1.3.0, 2.0.0
>
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENJPA-881) Enable connection pooling for testcases.

Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENJPA-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669920#action_12669920 ] 

Milosz Tylenda commented on OPENJPA-881:
----------------------------------------

Mike, I think specifying eviction stuff via dbcp.args is OK.


> Enable connection pooling for testcases. 
> -----------------------------------------
>
>                 Key: OPENJPA-881
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-881
>             Project: OpenJPA
>          Issue Type: Improvement
>    Affects Versions: 1.0.4, 1.1.1, 1.2.1, 1.3.0, 2.0.0
>            Reporter: Michael Dick
>            Assignee: Michael Dick
>
> Test configurations currently use dbcp with MaxIdle=0, effectively no connection pool. For Derby this doesn't have much of an effect but with other databases, like DB2, setting MaxIdle=2 can dramatically improve the time taken to run the tests. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.