You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 21:16:11 UTC

[GitHub] [beam] kennknowles opened a new issue, #18938: Move pom generation metadata logic out of build_rules.gradle

kennknowles opened a new issue, #18938:
URL: https://github.com/apache/beam/issues/18938

   When preparing a release, we generate pom files for each artifact to be released. Most of the pom structure is filled in automatically, but there is a good deal of metadata that needs to be manually added. The [code for manipulating the XML structure](https://github.com/apache/beam/blob/c78b96a67c0313f44d78262ee46f86aa4866a3aa/build_rules.gradle#L605) is verbose and it would make more sense to actually express it as XML rather than groovy DOM manipulations.
   
   It would be nice to refactor this and clean up the build_rules.gradle file a bit. Some potential ideas for refactoring:
    - Check in a "base pom.xml" file pre-filled with metadata, and use this as the source for generated pom manipulations.
    - Check in and release a parent pom file which contains all required metadata. Other artifacts can reference it as a parent and then drop the duplicated metadata.
    - At the very least, refactor the pom manipulation logic out to a different method or different file.
   
   Imported from Jira [BEAM-4050](https://issues.apache.org/jira/browse/BEAM-4050). Original Jira may contain additional context.
   Reported by: swegner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org