You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "solprovider (JIRA)" <ji...@apache.org> on 2007/12/29 22:10:43 UTC
[jira] Commented: (COCOON-2074) Build ignores custom applications
[ https://issues.apache.org/jira/browse/COCOON-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554955 ]
solprovider commented on COCOON-2074:
-------------------------------------
This version copies the directory with filtering="off", then overwrites the files requiring filtering="on"
FILE: webapp-build.xml
REPLACE WITH:
<copy todir="${build.webapp}" filtering="off">
<fileset dir="${webapp}"/>
</copy>
<copy file="${webapp}/welcome.xml" tofile="${build.webapp}/welcome.xml" filtering="on" overwrite="true"/>
<copy file="${webapp}/not-found.xml" tofile="${build.webapp}/not-found.xml" filtering="on" overwrite="true"/>
<copy file="${webapp}/welcome.xslt" tofile="${build.webapp}/welcome.xslt" filtering="on" overwrite="true"/>
<copy file="${webapp}/sitemap.xmap" tofile="${build.webapp}/sitemap.xmap" overwrite="true"/>
<copy todir="${build.webapp}/stylesheets" filtering="on" overwrite="true">
<fileset dir="${webapp}/stylesheets">
<include name="**/*.xslt"/>
</fileset>
</copy>
<copy todir="${build.webapp}/WEB-INF" filtering="on" overwrite="true">
<fileset dir="${webapp}/WEB-INF">
<include name="entities/**"/>
<include name="classes/**"/>
<include name="*.x*"/>
<include name="properties/**"/>
</fileset>
</copy>
> Build ignores custom applications
> ---------------------------------
>
> Key: COCOON-2074
> URL: https://issues.apache.org/jira/browse/COCOON-2074
> Project: Cocoon
> Issue Type: Improvement
> Components: - Build System: Ant
> Affects Versions: 2.1.10
> Reporter: solprovider
> Priority: Minor
> Fix For: 2.1.11-dev (Current SVN)
>
>
> The build process carefully adds each of the standard files in the webapp directory. New applications are not included in the build process. The improvement copies the entire directory. I did not notice any files needing to be excluded; any such files could be excluded from the fileset.
> webapp-build.xml
> CURRENT CODE:
> <copy file="${webapp}/welcome.xml" tofile="${build.webapp}/welcome.xml" filtering="on"/>
> <copy file="${webapp}/not-found.xml" tofile="${build.webapp}/not-found.xml" filtering="on"/>
> <copy file="${webapp}/welcome.xslt" tofile="${build.webapp}/welcome.xslt" filtering="on"/>
> <copy file="${webapp}/sitemap.xmap" tofile="${build.webapp}/sitemap.xmap"/>
> <!-- generate sitemap entries
> <sitemap-components sitemap="${build.webapp}/sitemap.xmap" source="${java}"/>
> -->
> <copy todir="${build.webapp}/stylesheets" filtering="on">
> <fileset dir="${webapp}/stylesheets">
> <include name="**/*.xslt"/>
> </fileset>
> </copy>
> <copy todir="${build.webapp}/resources" filtering="off">
> <fileset dir="${webapp}/resources"/>
> </copy>
> <copy todir="${build.webapp}/WEB-INF" filtering="on">
> <fileset dir="${webapp}/WEB-INF">
> <include name="entities/**"/>
> <include name="classes/**"/>
> <include name="*.x*"/>
> <include name="properties/**"/>
> </fileset>
> </copy>
> REPLACE WITH:
> <copy todir="${build.webapp}" filtering="on">
> <fileset dir="${webapp}"/>
> </copy>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (COCOON-2074) Build ignores custom applications
Posted by Vadim Gritsenko <va...@reverycodes.com>.
On Dec 29, 2007, at 4:10 PM, solprovider (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/COCOON-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
> #action_12554955 ]
>
> solprovider commented on COCOON-2074:
> -------------------------------------
>
> This version copies the directory with filtering="off", then
> overwrites the files requiring filtering="on"
>
> FILE: webapp-build.xml
> REPLACE WITH:
> <copy todir="${build.webapp}" filtering="off">
> <fileset dir="${webapp}"/>
You should add <exclude>s here and remove overwrite=true below. Using
'overwrite' here indicates bad tone: it doubles amount of work done by
the build script, and adds work (and increases the time) to the "do-
nothing" build.
Vadim
> </copy>
>
> <copy file="${webapp}/welcome.xml" tofile="${build.webapp}/
> welcome.xml" filtering="on" overwrite="true"/>
> <copy file="${webapp}/not-found.xml" tofile="${build.webapp}/not-
> found.xml" filtering="on" overwrite="true"/>
> <copy file="${webapp}/welcome.xslt" tofile="${build.webapp}/
> welcome.xslt" filtering="on" overwrite="true"/>
> <copy file="${webapp}/sitemap.xmap" tofile="${build.webapp}/
> sitemap.xmap" overwrite="true"/>
>
> <copy todir="${build.webapp}/stylesheets" filtering="on"
> overwrite="true">
> <fileset dir="${webapp}/stylesheets">
> <include name="**/*.xslt"/>
> </fileset>
> </copy>
>
> <copy todir="${build.webapp}/WEB-INF" filtering="on" overwrite="true">
> <fileset dir="${webapp}/WEB-INF">
> <include name="entities/**"/>
> <include name="classes/**"/>
> <include name="*.x*"/>
> <include name="properties/**"/>
> </fileset>
> </copy>