You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by cjmay <gi...@git.apache.org> on 2016/02/11 20:20:02 UTC

[GitHub] thrift pull request: THRIFT-3569 Add thrift_transport_read_all to ...

GitHub user cjmay opened a pull request:

    https://github.com/apache/thrift/pull/849

    THRIFT-3569 Add thrift_transport_read_all to facilitate large reads in c_glib

    Add a read_all method to the base transport class, following suit from the C++ library, and use it instead of the original read method in the protocol implementations.  This fixes a bug causing reads of large fields (e.g., string or binary fields) to fail, depending on the underlying transport and platform.  Test using a framed transport with a tiny frame size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjmay/thrift THRIFT-3569

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #849
    
----
commit 96172b11ac0608ae59ebea416a4cae1158195706
Author: Chandler May <cj...@gmail.com>
Date:   2016-02-11T13:25:25Z

    THRIFT-3569 Add thrift_transport_read_all to facilitate large reads in c_glib.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3569 Add thrift_transport_read_all to ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/849


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---