[GitHub] [flink] lirui-apache commented on a change in pull request #11524: [FLINK-16803][hive] Need to make sure partition inherit table spec wh…

[GitBox <gi...@apache.org>]

lirui-apache commented on a change in pull request #11524: [FLINK-16803][hive] Need to make sure partition inherit table spec wh…
URL: https://github.com/apache/flink/pull/11524#discussion_r401591732
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableMetaStoreFactory.java
 ##########
 @@ -105,6 +105,22 @@ public void createPartition(LinkedHashMap<String, String> partSpec, Path path) t
 			client.add_partition(partition);
 		}
 
+		@Override
+		public void alterPartition(LinkedHashMap<String, String> partitionSpec, Path partitionPath) throws Exception {
+			Partition partition = client.getPartition(database, tableName, new ArrayList<>(partitionSpec.values()));
+			StorageDescriptor partSD = partition.getSd();
 
 Review comment:
   I'd rather not. The logic is copied from Hive and it doesn't copy all the fields of the SD.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services