You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Vit Rozkovec <vi...@gmail.com> on 2018/02/19 14:45:07 UTC
DataTable toolbars
Hi,
I've come across one inconsistency in the DataTable class:
/**
* @return the container with the toolbars at the top
*/
public final ToolbarsContainer getTopToolbars()
{
return topToolbars;
}
/**
* @return the container with the toolbars at the bottom
*/
public final ToolbarsContainer getBottomToolbars()
{
return bottomToolbars;
}
ToolbarsContainer is defined as private, so those methods cannot be used
anyway. I suggest either changing the visibility of ToolbarsContainer or
removing those methods.
At the moment if I need to refresh toolbars, I have to go via datatable
component's get() method to remove all toolbar items and re-add them again.
Wicket 8x
Cheers
Vit
Re: DataTable toolbars
Posted by Vit Rozkovec <vi...@gmail.com>.
There you go: https://issues.apache.org/jira/browse/WICKET-6539
Vit
On 02/20/2018 05:06 PM, Martin Grigorov wrote:
> Hi,
>
> Please file a ticket!
> Thanks!
>
> Martin Grigorov
> Wicket Training and Consulting
> Looking for a remote position with Wicket ? Contact me!
> https://twitter.com/mtgrigorov
>
>
> On Mon, Feb 19, 2018 at 3:45 PM, Vit Rozkovec <vi...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I've come across one inconsistency in the DataTable class:
>>
>> /**
>> * @return the container with the toolbars at the top
>> */
>> public final ToolbarsContainer getTopToolbars()
>> {
>> return topToolbars;
>> }
>>
>> /**
>> * @return the container with the toolbars at the bottom
>> */
>> public final ToolbarsContainer getBottomToolbars()
>> {
>> return bottomToolbars;
>> }
>>
>>
>>
>> ToolbarsContainer is defined as private, so those methods cannot be used
>> anyway. I suggest either changing the visibility of ToolbarsContainer or
>> removing those methods.
>>
>> At the moment if I need to refresh toolbars, I have to go via datatable
>> component's get() method to remove all toolbar items and re-add them again.
>>
>> Wicket 8x
>>
>> Cheers
>> Vit
>>
>>
>>
>>
Re: DataTable toolbars
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Please file a ticket!
Thanks!
Martin Grigorov
Wicket Training and Consulting
Looking for a remote position with Wicket ? Contact me!
https://twitter.com/mtgrigorov
On Mon, Feb 19, 2018 at 3:45 PM, Vit Rozkovec <vi...@gmail.com>
wrote:
> Hi,
>
> I've come across one inconsistency in the DataTable class:
>
> /**
> * @return the container with the toolbars at the top
> */
> public final ToolbarsContainer getTopToolbars()
> {
> return topToolbars;
> }
>
> /**
> * @return the container with the toolbars at the bottom
> */
> public final ToolbarsContainer getBottomToolbars()
> {
> return bottomToolbars;
> }
>
>
>
> ToolbarsContainer is defined as private, so those methods cannot be used
> anyway. I suggest either changing the visibility of ToolbarsContainer or
> removing those methods.
>
> At the moment if I need to refresh toolbars, I have to go via datatable
> component's get() method to remove all toolbar items and re-add them again.
>
> Wicket 8x
>
> Cheers
> Vit
>
>
>
>