You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2012/04/09 19:21:46 UTC

svn commit: r1311339 - /lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Author: rmuir
Date: Mon Apr  9 17:21:46 2012
New Revision: 1311339

URL: http://svn.apache.org/viewvc?rev=1311339&view=rev
Log:
LUCENE-3969: don't use scary attsource ctor yet, and always print the analyzer for now

Modified:
    lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Modified: lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java?rev=1311339&r1=1311338&r2=1311339&view=diff
==============================================================================
--- lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java (original)
+++ lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java Mon Apr  9 17:21:46 2012
@@ -475,7 +475,9 @@ public class TestRandomChains extends Ba
         // TODO: maybe the collator one...???
         args[i] = AttributeFactory.DEFAULT_ATTRIBUTE_FACTORY;
       } else if (paramType == AttributeSource.class) {
-        args[i] = new AttributeSource();
+        // nocommit: args[i] = new AttributeSource();
+        // this is currently too scary to deal with!
+        args[i] = null; // force IAE
       } else {
         args[i] = newRandomArg(random, paramType);
       }
@@ -660,7 +662,8 @@ public class TestRandomChains extends Ba
     int numIterations = atLeast(20);
     for (int i = 0; i < numIterations; i++) {
       MockRandomAnalyzer a = new MockRandomAnalyzer(random.nextLong());
-      if (VERBOSE) {
+      // nocommit: wrap the uncaught handler with our own that prints the analyzer
+      if (true || VERBOSE) {
         System.out.println("Creating random analyzer:" + a);
       }
       try {



Re: svn commit: r1311339 - /lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Posted by Robert Muir <rc...@gmail.com>.
Hi,

currently there are tons of failures... i am trying to fix the easier
ones first.

so the test is simplified to not use this super-scary AttSource ctor
yet, because i get crazy failures with that.

thats why i added // nocommit.

On Mon, Apr 9, 2012 at 1:29 PM, Uwe Schindler <uw...@thetaphi.de> wrote:
>> LUCENE-3969: don't use scary attsource ctor yet
>
> That's not scary. Works fine. If it does not work, the Tokenizer is broken.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>



-- 
lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


RE: svn commit: r1311339 - /lucene/dev/branches/lucene3969/modules/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java

Posted by Uwe Schindler <uw...@thetaphi.de>.
> LUCENE-3969: don't use scary attsource ctor yet

That's not scary. Works fine. If it does not work, the Tokenizer is broken.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org