[jira] [Commented] (HBASE-13954) Remove HTableInterface#getRowOrBefore related server side code

["Ashish Singhi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628005#comment-14628005 ] 

Ashish Singhi commented on HBASE-13954:
---------------------------------------

While working on the patch I found that removing server side code is not so straight forward.
I can modify the existing logic of {{HRegion#getClosestRowBefore}} to reverse scan and remove code like GetCLosestRow*.
So with modification in code {{HRegion#getClosestRowBefore}}, {{Store#getRowKeyAtOrBefore}} is not used any more. Can I remove it ? I think no as it is marked {{@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC)}} so we should keep it deprecated for at least one major version, to remove it. But it will cause compilation error as I will be removing code like GetClosestRow* stuffs which is the motive of this jira. So I am thinking of marking it as deprecated and remove the existing implementation, is that ok ?

> Remove HTableInterface#getRowOrBefore related server side code
> --------------------------------------------------------------
>
>                 Key: HBASE-13954
>                 URL: https://issues.apache.org/jira/browse/HBASE-13954
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0
>
>
> As part of HBASE-13214 review, [~anoop.hbase] had a review comment on the review board to remove all the server side related code for getRowOrBefore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)