You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/08 17:44:48 UTC
[GitHub] [spark] shardulm94 opened a new pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
shardulm94 opened a new pull request #35444:
URL: https://github.com/apache/spark/pull/35444
This is a backport of https://github.com/apache/spark/pull/35332 to branch 3.1
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Canonicalization of AttributeReference should not remove nullability information of its dataType.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
SPARK-38030 lists an issue where canonicalization of cast resulted in an unresolved expression, thus causing query failure. The issue was that the child AttributeReference's dataType was converted to nullable during canonicalization and hence the Cast's `checkInputDataTypes` fails.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Added unit test to ensure that canonicalization preserves nullability of AttributeReference and does not result in an unresolved cast. Also added a test to ensure that the issue observed in SPARK-38030 (interaction of this bug with AQE) is fixed.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802181846
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should succeed with AQE") {
Review comment:
Added an explanation in the "How was this patch tested?" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802169214
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should succeed with AQE") {
Review comment:
Is there a reason why you provide this at `branch-3.1` PR only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35444:
URL: https://github.com/apache/spark/pull/35444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35444:
URL: https://github.com/apache/spark/pull/35444#issuecomment-1033052065
Thanks, @shardulm94 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802151142
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
##########
@@ -42,7 +42,7 @@ object Canonicalize {
/** Remove names and nullability from types, and names from `GetStructField`. */
private[expressions] def ignoreNamesTypes(e: Expression): Expression = e match {
case a: AttributeReference =>
- AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)
+ AttributeReference("none", a.dataType)(exprId = a.exprId)
Review comment:
The same comment on the branch-3.2 PR. We should update line 42 to be consistent.
```
- Remove names and nullability from types
+ Remove names from types
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35444:
URL: https://github.com/apache/spark/pull/35444#issuecomment-1033246763
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #35444:
URL: https://github.com/apache/spark/pull/35444#issuecomment-1033048569
@dongjoon-hyun 👍 I created a PR for 3.2 https://github.com/apache/spark/pull/35446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802171093
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should succeed with AQE") {
Review comment:
We encountered this issue in production when running Spark 3.1.1. However, this repro does not work on 3.2+. This is because the code which would previously trigger access on an unresolved object is [now lazy](https://github.com/apache/spark/blob/7e5c3b216431b6a5e9a0786bf7cded694228cdee/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L132) and hence does not trigger the issue in 3.2+, although the root cause still existed in 3.2+. So I only added this test in 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802172566
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should succeed with AQE") {
Review comment:
Could you put that explanation into the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35444: [SPARK-38030][SQL][3.1] Canonicalization should not remove nullability of AttributeReference dataType
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35444:
URL: https://github.com/apache/spark/pull/35444#discussion_r802171093
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1502,4 +1502,24 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-38030: Query with cast containing non-nullable columns should succeed with AQE") {
Review comment:
We encountered this issue in production when running Spark 3.1.1 (see the stacktrace in the JIRA for more details). However, this repro does not work on 3.2+. This is because the code which would previously trigger access on an unresolved object is [now lazy](https://github.com/apache/spark/blob/7e5c3b216431b6a5e9a0786bf7cded694228cdee/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L132) and hence does not trigger the issue in 3.2+, although the root cause still existed in 3.2+. So I only added this test in 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org