You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/09 11:49:55 UTC
[GitHub] sarveshkesharwani edited a comment on issue #956: [NETBEANS-1074]
Module Review web.jsf.editor
sarveshkesharwani edited a comment on issue #956: [NETBEANS-1074] Module Review web.jsf.editor
URL: https://github.com/apache/incubator-netbeans/pull/956#issuecomment-428162075
Matthias, Thanks for the review.
> Could you please explain the reason to post-process the javadoc file? From a first glance the file from maven central contained more documents, but they are not stripped.
The new jar from maven central contained many more documents than `jsf-api-docs.zip` (which only contained the javadoc), so while generating the new `generated-jsf-api-docs-2.0.zip`, I wanted to mimic the old `jsf-api-docs.zip` as much as possible. So, I removed all the extra files that were present in `javax.faces-api-2.0-javadoc.jar`. Which extra files do you see in the generated zip that are not yet stripped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists