You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/02/01 15:03:32 UTC

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support
URL: https://github.com/apache/incubator-livy/pull/141#discussion_r253080169
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala
 ##########
 @@ -183,11 +207,11 @@ abstract class SessionServlet[S <: Session, R <: RecoveryMetadata](
 
   private def doWithSession(fn: (S => Any),
       allowAll: Boolean,
-      checkFn: Option[(String, String) => Boolean]): Any = {
+      checkFn: Option[(Session, String) => Boolean]): Any = {
 
 Review comment:
   Change left over from checking the session proxy user. Will create separate JIRA for that change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services