[jira] [Resolved] (NET-643) NPE when closing telnet stream

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-643.
----------------------
       Resolution: Fixed
    Fix Version/s: 3.7

URL: http://svn.apache.org/viewvc?rev=1823550&view=rev
Log:
NET-643 NPE when closing telnet stream

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/telnet/TelnetClient.java


> NPE when closing telnet stream
> ------------------------------
>
>                 Key: NET-643
>                 URL: https://issues.apache.org/jira/browse/NET-643
>             Project: Commons Net
>          Issue Type: Bug
>          Components: Telnet
>    Affects Versions: 3.6
>         Environment: Observed in Android application. Some people encountered similar NPE on desktop years ago:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=395149
>            Reporter: Vasily
>            Priority: Major
>             Fix For: 3.7
>
>
> our code:
> {code:java}
> try {
>             TelnetClient telnetClient = new TelnetClient();
>             telnetClient.connect(address, port);
>             mInput = new BufferedInputStream(telnetClient.getInputStream());
>             mOutput = new PrintStream(telnetClient.getOutputStream());
>             BufferedReader br = new BufferedReader(new InputStreamReader(this.mInput));
>             ... some IO on streams ...
> } catch (IOException e) {
>             if (Dbg.DEBUG) {
>                 Dbg.d(TAG, "telnet exception " + Dbg.getStackTraceString(e));
>             }
>             return false;
> } finally {
>             try {
>                   if (mInput != null) mInput.close();
>                   if (mOutput != null) mOutput.close();
>             } catch (IOException ignored) {}
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)