You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/04/19 05:54:58 UTC
[PR] ORC-1695: Upgrade gson to 2.10.1 [orc]
cxzl25 opened a new pull request, #1897:
URL: https://github.com/apache/orc/pull/1897
### What changes were proposed in this pull request?
This PR aims to upgrade `Gson` to `2.10.1`.
### Why are the changes needed?
Jan 7, 2023
https://github.com/google/gson/releases/tag/gson-parent-2.10.1
Oct 25, 2022
https://github.com/google/gson/releases/tag/gson-parent-2.10
Aug 1, 2022
https://github.com/google/gson/releases/tag/gson-parent-2.9.1
### How was this patch tested?
GA
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1695: Upgrade gson to 2.10.1 [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1897: ORC-1695: Upgrade gson to 2.10.1
URL: https://github.com/apache/orc/pull/1897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1695: Upgrade gson to 2.10.1 [orc]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1897:
URL: https://github.com/apache/orc/pull/1897#discussion_r1571901095
##########
java/tools/src/test/resources/orc-file-dump.json:
##########
@@ -461,48 +461,48 @@
"numHashFunctions": 7,
"bitCount": 9600,
"popCount": 238,
- "loadFactor": 0.024791667237877846,
- "expectedFpp": 5.756256582500896E-12
+ "loadFactor": 0.024791667,
+ "expectedFpp": 5.7562566E-12
Review Comment:
The `com.google.gson.stream.JsonWriter#value(float)` method is not provided in gson 1.9.0, but is provided in gson 1.9.1.
https://github.com/google/gson/pull/2130
This causes the test to fail after upgrading gson, because in version 2.9.0, the generated json float will be implicitly converted to double.
### json format
https://github.com/apache/orc/blob/bd2af54a7aa8865f220d862eab024c27983ab85e/java/tools/src/java/org/apache/orc/tools/JsonFileDump.java#L426-L432
### not json format
https://github.com/apache/orc/blob/bd2af54a7aa8865f220d862eab024c27983ab85e/java/tools/src/java/org/apache/orc/tools/FileDump.java#L719-L726
For other test files in non-json format, we can see that the loadFactor is float.
https://github.com/apache/orc/blob/bd2af54a7aa8865f220d862eab024c27983ab85e/java/tools/src/test/resources/orc-file-dump-bloomfilter2.out#L68-L69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1695: Upgrade gson to 2.10.1 [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1897:
URL: https://github.com/apache/orc/pull/1897#issuecomment-2066870594
Merged to main/2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org