You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/03/03 23:00:42 UTC

[GitHub] beam pull request #2156: Use CreatePCollectionView explicitly in CombineGlob...

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2156

    Use CreatePCollectionView explicitly in CombineGloballyAsSingletonView

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Implement View.asSingleton as a CombineGloballyAsSingletonView.
    
    This stops any writing of a SingletonView that is not actually a
    Singleton View. - i.e. the contents (which can never be read) cannot
    be provided to the View.CreatePCollectionView transform, as they must
    go through a combiner before they arrive.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam combine_globally_as_singleton_view_writes_view_explicitly

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2156
    
----
commit ce9391ada42b98963ad45ab20daaa2ec403b4926
Author: Thomas Groh <tg...@google.com>
Date:   2017-03-03T21:29:34Z

    Use CreatePCollectionView explicitly in CombineGloballyAsSingletonView
    
    Implement View.asSingleton as a CombineGloballyAsSingletonView.
    
    This stops any writing of a SingletonView that is not actually a
    Singleton View.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2156: [BEAM-1743] Use CreatePCollectionView explicitly in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2156


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---