You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/05/19 18:53:45 UTC
[kudu-CR] Fix inaccuracy in LICENSE.txt regarding MIT license
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6929
to review the following change.
Change subject: Fix inaccuracy in LICENSE.txt regarding MIT license
......................................................................
Fix inaccuracy in LICENSE.txt regarding MIT license
LICENSE.txt incorrectly stated that the MIT license doesn't require
copyright notices to be propagated to binary distributions. That is true
only of the Boost license.
It is sort of a moot point because the only MIT license software that
was listed in the relevant section is a build-time-only dependency, and
thus doesn't need to be propagated up. But, better to be accurate so
that future additions aren't treated incorrectly.
Change-Id: I872a9b5845b761bdf6980e4d9eea68b2970ef9bc
---
M LICENSE.txt
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6929/1
--
To view, visit http://gerrit.cloudera.org:8080/6929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I872a9b5845b761bdf6980e4d9eea68b2970ef9bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Fix inaccuracy in LICENSE.txt regarding MIT license
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix inaccuracy in LICENSE.txt regarding MIT license
......................................................................
Fix inaccuracy in LICENSE.txt regarding MIT license
LICENSE.txt incorrectly stated that the MIT license doesn't require
copyright notices to be propagated to binary distributions. That is true
only of the Boost license.
It is sort of a moot point because the only MIT license software that
was listed in the relevant section is a build-time-only dependency, and
thus doesn't need to be propagated up. But, better to be accurate so
that future additions aren't treated incorrectly.
Change-Id: I872a9b5845b761bdf6980e4d9eea68b2970ef9bc
Reviewed-on: http://gerrit.cloudera.org:8080/6929
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M LICENSE.txt
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I872a9b5845b761bdf6980e4d9eea68b2970ef9bc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix inaccuracy in LICENSE.txt regarding MIT license
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix inaccuracy in LICENSE.txt regarding MIT license
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I872a9b5845b761bdf6980e4d9eea68b2970ef9bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No