You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/12/08 20:08:59 UTC
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19331
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
Without HIVE-24498 we get java.lang.NoClassDefFoundError exceptions
when we write Iceberg tables via Hive. This makes it hard to write
interop tests between Hive and Impala which use Iceberg tables.
I also exclude some private Java components to get things built.
Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
---
M bin/impala-config.sh
M fe/pom.xml
M java/executor-deps/pom.xml
3 files changed, 35 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/19331/1
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:14:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8890/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 09:09:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 14:16:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
Without HIVE-24498 we get java.lang.NoClassDefFoundError exceptions
when we write Iceberg tables via Hive. This makes it hard to write
interop tests between Hive and Impala which use Iceberg tables.
I also exclude some private Java components to get things built.
Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Reviewed-on: http://gerrit.cloudera.org:8080/19331
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@apache.org>
---
M bin/impala-config.sh
M fe/pom.xml
M java/executor-deps/pom.xml
3 files changed, 35 insertions(+), 11 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laszlo Gaal: Looks good to me, but someone else must approve
Tamas Mate: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1:
LGTM, thanks for this bump!
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Tue, 13 Dec 2022 12:14:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12011/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Dec 2022 20:28:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11777: Bump CDP BUILD NUMBER to get HIVE-24498
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19331 )
Change subject: IMPALA-11777: Bump CDP_BUILD_NUMBER to get HIVE-24498
......................................................................
Patch Set 1: Code-Review+1
LGTM; +1 to let Joe take a look as well.
--
To view, visit http://gerrit.cloudera.org:8080/19331
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I486c2b1b224f72e082e331a57cf25a37ebb9fa54
Gerrit-Change-Number: 19331
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 15:25:23 +0000
Gerrit-HasComments: No