[GitHub] [arrow-rs] tustvold opened a new pull request, #4048: Add offsets accessors to variable length arrays (#3879)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold opened a new pull request, #4048:
URL: https://github.com/apache/arrow-rs/pull/4048

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of #3879
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   This provides access to the typed buffer abstractions, which allows for destructing of arrays. I opted to add new functions, instead of changing the return types of `value_data` and `value_offsets` to reduce code churn, and also because the value prefix is a tad redundant. I expect we may eventually deprecate and remove the old methods.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4048: Add offsets accessors to variable length arrays (#3879)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold merged PR #4048:
URL: https://github.com/apache/arrow-rs/pull/4048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on a diff in pull request #4048: Add offsets accessors to variable length arrays (#3879)

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #4048:
URL: https://github.com/apache/arrow-rs/pull/4048#discussion_r1162717784


##########
arrow-array/src/array/byte_array.rs:
##########
@@ -67,6 +67,18 @@ impl<T: ByteArrayType> GenericByteArray<T> {
         offsets[i + 1] - offsets[i]
     }
 
+    /// Returns a reference to the offsets of this array

Review Comment:
   I think it might help to note in the docstrings:
   1. How this is different than `value_offsets` (other than the signature)
   2. Which is preferred (it sounds from this PR's description that `offsets` is preferred, but that is not obvious from the code as it is written)
   
   The same applies to `values` and `value_data`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org