You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "arshadmohammad (via GitHub)" <gi...@apache.org> on 2024/08/30 16:54:49 UTC
[I] [Improvement] [Seatunnel-web] Improve code in DatasourceServiceImpl,SeaTunnelEngineMetricsExtractor etc. [seatunnel]
arshadmohammad opened a new issue, #7538:
URL: https://github.com/apache/seatunnel/issues/7538
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues.
### What happened
While fixing bugs, had noted down few code improvement.
JobExecParamUtil and JobUtils need to be renamed as per their usage and context.
DatasourceServiceImpl is making extra DB call.
SeaTunnelEngineMetricsExtractor, and DatasourceServiceImpl have some duplicate codes.
Setting cluster name is redundant.
### SeaTunnel Version
NA
### SeaTunnel Config
```conf
NA
```
### Running Command
```shell
NA
```
### Error Exception
```log
NA
```
### Zeta or Flink or Spark Version
_No response_
### Java or Scala Version
_No response_
### Screenshots
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement] [Seatunnel-web] Improve code in DatasourceServiceImpl,SeaTunnelEngineMetricsExtractor etc. [seatunnel]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X closed issue #7538: [Improvement] [Seatunnel-web] Improve code in DatasourceServiceImpl,SeaTunnelEngineMetricsExtractor etc.
URL: https://github.com/apache/seatunnel/issues/7538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Improvement] [Seatunnel-web] Improve code in DatasourceServiceImpl,SeaTunnelEngineMetricsExtractor etc. [seatunnel]
Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on issue #7538:
URL: https://github.com/apache/seatunnel/issues/7538#issuecomment-2322027986
Raised PR https://github.com/apache/seatunnel-web/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org