You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "messere1 (via GitHub)" <gi...@apache.org> on 2026/08/11 08:36:10 UTC
[I] [studio][Bug] System theme crashes in legacy matchMedia implementations [rocketmq-dashboard]
messere1 opened a new issue, #1690:
URL: https://github.com/apache/rocketmq-dashboard/issues/1690
### Description
`ThemeProvider` supports a missing `window.matchMedia`, but when it exists the provider unconditionally calls `MediaQueryList.addEventListener` and `removeEventListener`.
Older Safari versions and embedded WebViews expose the legacy `addListener` / `removeListener` API without the EventTarget methods. In those environments, opening RocketMQ Studio with no stored manual theme throws during the provider effect and can break application rendering.
### Expected behavior
System-theme following should subscribe through the modern change event API when available and fall back to the legacy listener API otherwise. Cleanup should use the matching removal method.
### Actual behavior
A legacy-only MediaQueryList causes `addEventListener is not a function`.
### Proposed fix
Feature-detect the MediaQueryList event methods, add a legacy fallback, and cover initial rendering, change notification, and listener cleanup with a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] System theme crashes in legacy matchMedia implementations [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1690:
URL: https://github.com/apache/rocketmq-dashboard/issues/1690#issuecomment-5363575115
This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] System theme crashes in legacy matchMedia implementations [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #1690:
URL: https://github.com/apache/rocketmq-dashboard/issues/1690#issuecomment-5251155595
**Issue Evaluation**
Category: `question` | Status: **Needs Info**
Thank you for reporting this issue. However, automated verification found that the referenced code components do not exist in the current `apache/rocketmq-dashboard` codebase (checked on `main` branch).
The classes, endpoints, and files mentioned in this issue (e.g., Studio-specific controllers, providers, and frontend components) appear to belong to a separate **RocketMQ Studio** project that has not been merged into this repository.
**To help us triage this correctly, please clarify:**
- [ ] Is this issue targeting a different repository (e.g., a separate `rocketmq-studio` repo)?
- [ ] Is the Studio code available on a feature branch that needs to be merged first?
- [ ] Should this issue be filed against a different project?
Once clarified, we will re-classify and proceed with verification.
---
*Automated evaluation by @RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [studio][Bug] System theme crashes in legacy matchMedia implementations [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #1690: [studio][Bug] System theme crashes in legacy matchMedia implementations
URL: https://github.com/apache/rocketmq-dashboard/issues/1690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org