[GitHub] [flink] dannycranmer commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…

["dannycranmer (via GitHub)" <gi...@apache.org>]

dannycranmer commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1150564908


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
     public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
         if (validator.test(err)) {
             throwableConsumer.accept(throwableMapper.apply(err));
-            return false;
+            return true;

Review Comment:
   @DavidLiu001 thanks for the PR but this change is very dangerous as-is, since we are inverting the semantics of the code. This is not a backward compatible change. Instead of changing this, can we 1/ `@Deprecate` the existing implementation and 2/ introduce new code that is cleaner. We can remove the deprecated version in a future Flink version.
   
   Side comment I am concerned that no tests failed with this! Seems there is a gap in the unit tests. Can you please add a test for this or raise a Jira to cover that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org