[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #354: [FLINK-29840] Fix bug that old record may overwrite new record in Table Store when snapshot committing is slow

[GitBox <gi...@apache.org>]

LadyForest commented on code in PR #354:
URL: https://github.com/apache/flink-table-store/pull/354#discussion_r1014946479


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreWrite.java:
##########
@@ -48,17 +49,20 @@
  */
 public abstract class AbstractFileStoreWrite<T> implements FileStoreWrite<T> {
 
+    private final String commitUser;
     private final SnapshotManager snapshotManager;
     private final FileStoreScan scan;
 
     @Nullable protected IOManager ioManager;
 
-    protected final Map<BinaryRowData, Map<Integer, RecordWriter<T>>> writers;
+    protected final Map<BinaryRowData, Map<Integer, WriterAndCommit<T>>> writers;

Review Comment:
   Nit: `WriterAndCommit` => `WriterWithCommit`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org