[GitHub] [spark] grundprinzip commented on a diff in pull request #40695: [SPARK-42994][ML][CONNECT] PyTorch Distributor support Local Mode with GPU

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #40695:
URL: https://github.com/apache/spark/pull/40695#discussion_r1161204815


##########
python/pyspark/sql/connect/client.py:
##########
@@ -867,6 +878,8 @@ def _analyze(self, method: str, **kwargs: Any) -> AnalyzeResult:
                 req.unpersist.blocking = cast(bool, kwargs.get("blocking"))
         elif method == "get_storage_level":
             req.get_storage_level.relation.CopyFrom(cast(pb2.Relation, kwargs.get("relation")))
+        elif method == "resources":

Review Comment:
   I'm not sure this is a good approach as it overloads the semantics of analyze with generic system metadata information. 
   
   My suggestion is to implement resource metadata using a command instead. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org