You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by mengxr <gi...@git.apache.org> on 2014/02/12 19:39:29 UTC
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
GitHub user mengxr opened a pull request:
https://github.com/apache/incubator-spark/pull/589
SPARK-1076: Convert Int to Long to avoid overflow
Patch for PR #578.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-spark/pull/589.patch
----
commit 98c435eebd74dcfe57212ff5d240b8a00a5d0bdf
Author: Xiangrui Meng <me...@databricks.com>
Date: 2014-02-12T18:34:02Z
cast Int to Long to avoid Int overflow
----
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34906057
I will make another PR for the second commit. Next time we should leave the PR open for a day or half before merge.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr closed the pull request at:
https://github.com/apache/incubator-spark/pull/589
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34905626
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12694/
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34904375
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12693/
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34901044
Merged build triggered.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34900982
LGTM
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34901501
Thanks. Merged.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34905810
Uh-oh, @rxin did your merge include the second commit?
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34901047
Merged build started.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34902192
Merged build triggered.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34904374
Merged build finished.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34902193
Merged build started.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34908063
Timely merges may not have been the problem -- the title of this PR only mentions the change you had already made :)
Please signal if your PR is not ready to be reviewed in full.
[GitHub] incubator-spark pull request: SPARK-1076: Convert Int to Long to a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/589#issuecomment-34905625
Merged build finished.