You are viewing a plain text version of this content. The canonical link for it is here.
Posted to m2-dev@maven.apache.org by tr...@apache.org on 2004/08/03 20:33:37 UTC

cvs commit: maven-components/maven-core/src/test/java/org/apache/maven/project/validation DefaultModelValidatorTest.java

trygvis     2004/08/03 11:33:37

  Modified:    maven-core/src/test/java/org/apache/maven/project/validation
                        DefaultModelValidatorTest.java
  Log:
  o Updating test case.
  
  Revision  Changes    Path
  1.3       +22 -11    maven-components/maven-core/src/test/java/org/apache/maven/project/validation/DefaultModelValidatorTest.java
  
  Index: DefaultModelValidatorTest.java
  ===================================================================
  RCS file: /home/cvs/maven-components/maven-core/src/test/java/org/apache/maven/project/validation/DefaultModelValidatorTest.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- DefaultModelValidatorTest.java	24 Jun 2004 00:10:18 -0000	1.2
  +++ DefaultModelValidatorTest.java	3 Aug 2004 18:33:37 -0000	1.3
  @@ -22,14 +22,14 @@
   
       private ModelValidator validator;
   
  -    public void testMissingArtifactId()
  +    public void testMissingModelVersion()
           throws Exception
       {
  -        ModelValidationResult result = validate( "missing-artifactId-pom.xml" );
  +        ModelValidationResult result = validate( "missing-modelVersion-pom.xml" );
   
           assertEquals( 1, result.getMessageCount() );
   
  -        assertEquals( "'artifactId' is missing.", result.getMessage( 0 ) );
  +        assertEquals( "'modelVersion' must be set.", result.getMessage( 0 ) );
       }
   
       public void testMissingGroupId()
  @@ -39,7 +39,17 @@
       
           assertEquals( 1, result.getMessageCount() );
       
  -        assertEquals( "'groupId' is missing.", result.getMessage( 0 ) );
  +        assertEquals( "'groupId' must be set.", result.getMessage( 0 ) );
  +    }
  +
  +    public void testMissingArtifactId()
  +        throws Exception
  +    {
  +        ModelValidationResult result = validate( "missing-artifactId-pom.xml" );
  +
  +        assertEquals( 1, result.getMessageCount() );
  +
  +        assertEquals( "'artifactId' must be set.", result.getMessage( 0 ) );
       }
   
       public void testMissingType()
  @@ -49,7 +59,7 @@
       
           assertEquals( 1, result.getMessageCount() );
       
  -        assertEquals( "'type' is empty.", result.getMessage( 0 ) );
  +        assertEquals( "'type' cannot be empty.", result.getMessage( 0 ) );
       }
   
       public void testMissingVersion()
  @@ -59,7 +69,7 @@
       
           assertEquals( 1, result.getMessageCount() );
   
  -        assertEquals( "'version' is missing.", result.getMessage( 0 ) );
  +        assertEquals( "'version' must be set.", result.getMessage( 0 ) );
       }
   
       public void testMissingAll()
  @@ -67,12 +77,13 @@
       {
           ModelValidationResult result = validate( "missing-1-pom.xml" );
       
  -        assertEquals( 3, result.getMessageCount() );
  +        assertEquals( 4, result.getMessageCount() );
   
  -        assertEquals( "'groupId' is missing.", result.getMessage( 0 ) );
  -        assertEquals( "'artifactId' is missing.", result.getMessage( 1 ) );
  +        assertEquals( "'modelVersion' must be set.", result.getMessage( 0 ) );
  +        assertEquals( "'groupId' must be set.", result.getMessage( 1 ) );
  +        assertEquals( "'artifactId' must be set.", result.getMessage( 2 ) );
           // type is inherited from the super pom
  -        assertEquals( "'version' is missing.", result.getMessage( 2 ) );
  +        assertEquals( "'version' must be set.", result.getMessage( 3 ) );
       }
   
       private ModelValidationResult validate( String testName )