You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/03 22:25:48 UTC

[GitHub] dorq commented on issue #6565: [Design Proposal] Improve SQL Lab Editor Resizer

dorq commented on issue #6565: [Design Proposal] Improve SQL Lab Editor Resizer
URL: https://github.com/apache/incubator-superset/issues/6565#issuecomment-451297191
 
 
   I agree with @thinmatt that we need an additional UI element to indicate the panel is resizable.  Also agree with making "the SQL toolbar visually match up with the editor pane -- that way the resizer is the true visual edge of the editor pane".
   
   How about this, which would accomplish both of the above without introducing buttons overlaid on query text?
   
   ![sql lab pull](https://user-images.githubusercontent.com/2992086/50664846-53958e80-0f63-11e9-89a7-5439c08ecb85.png)
   
   We could also consider, as @vylc mentioned, moving the action buttons to the lower right where the current "parameters" and timer are, but I think that update addresses a different issue than this ticket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org