You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/28 02:32:04 UTC
[GitHub] [tvm] shanmo opened a new pull request, #11487: [rust] update ndarray version
shanmo opened a new pull request, #11487:
URL: https://github.com/apache/tvm/pull/11487
Update the ndarray version to the latest, otherwise there are conflicts, the error message is `note: perhaps two different versions of crate `ndarray` are being used?` @nhynes
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] nhynes commented on pull request #11487: [rust] update ndarray version
Posted by GitBox <gi...@apache.org>.
nhynes commented on PR #11487:
URL: https://github.com/apache/tvm/pull/11487#issuecomment-1139798655
> Yes it is 0.15, in fact it's because some other packages such as numpy require the latest version of ndarray, so I have to use 0.15.
I have no problem bumping this version, but I can't approve your PR. In the meantime, may I suggest importing both versions like
```toml
ndarray_0_12 = { version = "0.12", package = "ndarray" }
ndarray = "0.15"
```
and making liberal use of `From` and other manual conversions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shanmo commented on pull request #11487: [rust] update ndarray version
Posted by GitBox <gi...@apache.org>.
shanmo commented on PR #11487:
URL: https://github.com/apache/tvm/pull/11487#issuecomment-1140146086
> > Yes it is 0.15, in fact it's because some other packages such as numpy require the latest version of ndarray, so I have to use 0.15.
>
> I have no problem bumping this version, but I can't approve your PR. In the meantime, may I suggest importing both versions like
>
> ```toml
> ndarray_0_12 = { version = "0.12", package = "ndarray" }
> ndarray = "0.15"
> ```
>
> and making liberal use of `From` and other manual conversions?
Sounds good, thanks for the advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shanmo commented on pull request #11487: [rust] update ndarray version
Posted by GitBox <gi...@apache.org>.
shanmo commented on PR #11487:
URL: https://github.com/apache/tvm/pull/11487#issuecomment-1139628174
Yes it is `0.15`, in fact it's because some other packages such as `numpy` require the latest version of `ndarray`, so I have to use `0.15`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] nhynes commented on pull request #11487: [rust] update ndarray version
Posted by GitBox <gi...@apache.org>.
nhynes commented on PR #11487:
URL: https://github.com/apache/tvm/pull/11487#issuecomment-1139568161
What version of `ndarray` are you using in your application code? `0.15`, I'm guessing. If you use `0.12`, it'll work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shanmo closed pull request #11487: [rust] update ndarray version
Posted by GitBox <gi...@apache.org>.
shanmo closed pull request #11487: [rust] update ndarray version
URL: https://github.com/apache/tvm/pull/11487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org