You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Lchangliang (via GitHub)" <gi...@apache.org> on 2023/02/10 12:21:59 UTC
[GitHub] [doris] Lchangliang opened a new issue, #16623: [Bug] Cancel Schema change job is useless in BE
Lchangliang opened a new issue, #16623:
URL: https://github.com/apache/doris/issues/16623
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
### Version
1.2 or master also
### What's Wrong?
When I have a long schema change job, I want to cancel it and create a new schema change job. It fails sometime.
Example:
I has a large table that has many columns. I choose column A to add bitmap index. But i regret it. I want to add bitmap index for column B. So I cancel the job, and create a new schema change job and then the job fails.
LOG:
W0206 17:32:49.308645 1579747 schema_change.cpp:1751] failed to obtain schema change lock. base_tablet=12198
W0206 17:32:49.354110 1579747 task_worker_pool.cpp:558] failed to alter tablet|signature=12450|base_tablet_id=12198|new_tablet_id=12450|error=Internal error(error -216): @ 0x55e5ed6fb0a4 doris::Status::ConstructErrorStatus()
@ 0x55e5ed6fb565 doris::Status::OLAPInternalError()
@ 0x55e5edb0821c doris::SchemaChangeHandler::process_alter_tablet_v2()
@ 0x55e5edf1df00 doris::EngineAlterTabletTask::execute()
@ 0x55e5eda9c019 doris::StorageEngine::execute_task()
@ 0x55e5edab9612 doris::TaskWorkerPool::_alter_tablet()
@ 0x55e5edac6819 doris::TaskWorkerPool::_alter_tablet_worker_thread_callback()
@ 0x55e5ee2a5805 doris::ThreadPool::dispatch_thread()
@ 0x55e5ee29bbef doris::Thread::supervise_thread()
@ 0x7f6fa610b17a start_thread
@ 0x7f6fa641fdc3 __GI___clone
@ (nil) (unknown)
The code in fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:CancelImpl is about the cancel. And we can learn that the cancel just happens in FE. It will not cancel the workflow in BE and BE will do the cancel job until finish. It can make things weird. I cancel the job, but I fail to add new job.
### What You Expected?
When input the cancel command, the schema change job will be canceled completely.
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE
Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1425755136
https://doris.apache.org/zh-CN/docs/dev/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-TABLE-BITMAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE
Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1425752183
I think we can use the ssb case generated by tools dir (tools/ssb-tools). Generate 100 gigabytes of data for the table lineorder and choose two columns to simulate the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] isHuangXin commented on issue #16623: [Bug] Cancel Schema change job is useless in BE
Posted by "isHuangXin (via GitHub)" <gi...@apache.org>.
isHuangXin commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1425747154
Can you give a more detailed test case?
For example, create a table, create a bitmap index for column A, and the SQL script to cancel the bitmap index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] isHuangXin commented on issue #16623: [Bug] Cancel Schema change job is useless in BE
Posted by "isHuangXin (via GitHub)" <gi...@apache.org>.
isHuangXin commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1425759089
plz assign it to me~ I will have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on issue #16623: [Bug] Cancel Schema change job which is useless in BE
Posted by "TangSiyang2001 (via GitHub)" <gi...@apache.org>.
TangSiyang2001 commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1500767701
Let me have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [I] [Bug] Cancel Schema change job which is useless in BE [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman closed issue #16623: [Bug] Cancel Schema change job which is useless in BE
URL: https://github.com/apache/doris/issues/16623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Lchangliang commented on issue #16623: [Bug] Cancel Schema change job is useless in BE
Posted by "Lchangliang (via GitHub)" <gi...@apache.org>.
Lchangliang commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1425755540
CANCEL ALTER TABLE COLUMN FROM tbl_name;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] isHuangXin commented on issue #16623: [Bug] Cancel Schema change job which is useless in BE
Posted by "isHuangXin (via GitHub)" <gi...@apache.org>.
isHuangXin commented on issue #16623:
URL: https://github.com/apache/doris/issues/16623#issuecomment-1465744960
plz, unassign me, sry for not completing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org