You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/02/07 16:19:57 UTC

[GitHub] [zeppelin] omrisk opened a new pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

omrisk opened a new pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048


   ### What is this PR for?
   Fixing some typos from the tutorials notebook
   
   ### What type of PR is it?
   Documentation
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   [ZEPPELIN-5241](https://issues.apache.org/jira/browse/ZEPPELIN-5241)
   
   ### How should this be tested?
   * Standard CI tests
   * 
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? - no
   * Is there breaking changes for older versions? - no
   * Does this needs documentation? - no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] omrisk commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-776632673


   Thanks @zjffdu! Happy to help.
   I see that there are still failing build tests.
   Couldn't find an open ticket or PR to fix this, is there a way I could help with that ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-776620343


   Thanks for the contribution @omrisk 
   PR LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-777221707


   Will merge it soon, and here's a list of jiras for new contributors
   https://issues.apache.org/jira/issues/?jql=labels%20%3D%20newbie%20and%20project%20%3D%20ZEPPELIN


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-776769807


   @omrisk Failure of `Neo4jCypherInterpreterTest` is fixed by a recent PR #4050 (You can could rebase this PR to fix it)
   but there still some flaky tests in selenium test (frontend test) that needs to fix, but I think it would not be easy, so we could do it separately. BTW, if you are interested in making contribution to zeppelin, you can pick up any tickets in jira, and we will help you in making contribution.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] omrisk commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
omrisk commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-777212206


   @zjffdu , thanks, could you please merge this?
   I'll try to find a beginner friendly jira issue :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] zjffdu commented on pull request #4048: [ZEPPELIN-5241] Typos in spark tutorial

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4048:
URL: https://github.com/apache/zeppelin/pull/4048#issuecomment-776632182


   Will merge if no more comment


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org