Re: [PR] [DRAFT]chore: refactor E2E tests to support parallel tests [apisix-ingress-controller]

["github-advanced-security[bot] (via GitHub)" <gi...@apache.org>]

github-advanced-security[bot] commented on code in PR #2501:
URL: https://github.com/apache/apisix-ingress-controller/pull/2501#discussion_r2247718834


##########
test/e2e/crds/v1alpha1/gatewayproxy.go:
##########
@@ -108,9 +87,37 @@
     - name: httpbin-service-e2e-test
       port: 80
 `
+
+	const gatewayProxySpec = `
+apiVersion: apisix.apache.org/v1alpha1
+kind: GatewayProxy
+metadata:
+  name: apisix-proxy-config
+spec:
+  provider:
+    type: ControlPlane
+    controlPlane:
+      service:
+        name: %s
+        port: 9180
+      auth:
+        type: AdminKey
+        adminKey:
+          value: "%s"
+  plugins:
+  - name: response-rewrite
+    enabled: true
+    config: 
+      headers:
+        "X-Pod-Hostname": "$hostname"
+`
+
 	BeforeEach(func() {
+		gatewayName := s.Namespace()
 		By("create GatewayProxy")
-		err = s.CreateResourceFromString(fmt.Sprintf(gatewayProxySpec, framework.ProviderType, s.AdminKey()))
+		gatewayProxy := fmt.Sprintf(gatewayProxySpec, framework.ProviderType, s.AdminKey())
+		err = s.CreateResourceFromString(gatewayProxy)
+		fmt.Println("GATEWAY PROXY IS ", gatewayProxy)

Review Comment:
   ## Clear-text logging of sensitive information
   
   [Sensitive data returned by an access to APISIXAdminAPIKey](1) flows to a logging call.
   
   [Show more details](https://github.com/apache/apisix-ingress-controller/security/code-scanning/3)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org