[GitHub] [james-project] chibenwa commented on a change in pull request #484: JAMES-2886 Fix collection handling for PropertiesProvider

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #484:
URL: https://github.com/apache/james-project/pull/484#discussion_r647327141



##########
File path: server/container/guice/configuration/src/main/java/org/apache/james/utils/PropertiesProvider.java
##########
@@ -43,11 +43,20 @@
 import com.google.common.base.Strings;
 
 public class PropertiesProvider {
-
     private static final Logger LOGGER = LoggerFactory.getLogger("org.apache.james.CONFIGURATION");
     private static final char COMMA = ',';
     private static final String COMMA_STRING = ",";
 
+    public static Configuration getConfiguration(File propertiesFile) throws ConfigurationException {

Review comment:
       Maybe I could annotate it with `@VisibleForTesting` to make the intent clear?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org