You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/07 16:31:33 UTC
[GitHub] [apisix] membphis opened a new pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
membphis opened a new pull request #2023:
URL: https://github.com/apache/apisix/pull/2023
…g-default.yaml .
fix #1923 .
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-674520848
need to resolve conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-671145794
> How about allowing user to specify the path of `config.yaml` ?
that is another feature, we can implement it in a single PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2023:
URL: https://github.com/apache/apisix/pull/2023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-674457540
this pr is still a draft now..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen edited a comment on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-674457540
this pr is still a draft now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-674468242
> this pr is still a draft now ?
missing doc. I'll add this later. but this feature is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen edited a comment on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
nic-chen edited a comment on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-671043910
LGTM.
How about allowing user to specify the path of `config.yaml` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2023:
URL: https://github.com/apache/apisix/pull/2023#issuecomment-671043910
LGTM.
But how about allow user to specify the path of `config.yaml`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org