[GitHub] [hudi] codope commented on a change in pull request #4118: [HUDI-2774] Merge duplicate instants while fetching pending clustering plans

[GitBox <gi...@apache.org>]

codope commented on a change in pull request #4118:
URL: https://github.com/apache/hudi/pull/4118#discussion_r756992163



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/ClusteringUtils.java
##########
@@ -124,7 +124,7 @@
         // get all filegroups in the plan
         getFileGroupEntriesInClusteringPlan(clusteringPlan.getLeft(), clusteringPlan.getRight()));
 
-    Map<HoodieFileGroupId, HoodieInstant> resultMap = resultStream.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
+    Map<HoodieFileGroupId, HoodieInstant> resultMap = resultStream.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue, (i1, i2) -> i1));

Review comment:
       yeah that's right. i thought about repetitive scheduling but such race scenarios are hard to avoid.. one way is as you suggested in the ticket i.e. to add some default `--min-sync-interval` but i felt that might give users the impression that job itself is taking longer than usual.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org