You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/23 09:11:35 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
yaooqinn opened a new pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
In this PR, we handle newly added daytime interval type
TTypeId.INTERVAL_DAY_TIME_TYPE is used for compatible hive thrift type.
jdbc Type is java.sql.Types.OTHER
The data is converted from java duration to hive compatible string representation
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199#discussion_r833053817
##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/IntervalQualifier.scala
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.engine.spark.schema
+
+import java.time.Duration
+import java.util.concurrent.TimeUnit
+
+object IntervalQualifier extends Enumeration {
+
+ type IntervalQualifier = Value
+
+ val DAY = new Val(0, "interval day")
+ val HOUR = new Val(1, "interval day to hour")
+ val MINUTE = new Val(3, "interval day to minute")
Review comment:
any reason not use `2` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas removed a comment on pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199#issuecomment-1076514736
@pan3793 @ulysses-you @Nick-0723 , thanks for your work. Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] Nick-0723 commented on pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
Nick-0723 commented on pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199#issuecomment-1077253889
I found that DayTimeIntervalType is not fully implemented，and I will complete it at #2207
<img width="796" alt="image" src="https://user-images.githubusercontent.com/31242104/159851331-b282d1f9-e65b-40dc-bc78-72cf18c8d61e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199#issuecomment-1077263870
> I found that DayTimeIntervalType is not fully implemented，and I will complete it at #2207 <img alt="image" width="796" src="https://user-images.githubusercontent.com/31242104/159851331-b282d1f9-e65b-40dc-bc78-72cf18c8d61e.png">
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199#issuecomment-1076128384
cc @pan3793 @ulysses-you
Hi, @Nick-0723 you can work on YearMonthIntervalType/TimestampNTZType after we finish this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas closed pull request #2199: [KYUUBI #2186] Manage test failures with kyuubi spark nightly build - execute statement - select interval
Posted by GitBox <gi...@apache.org>.
SteNicholas closed pull request #2199:
URL: https://github.com/apache/incubator-kyuubi/pull/2199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org