You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Johannes Fahrenkrug (JIRA)" <ji...@apache.org> on 2007/06/07 12:20:25 UTC
[jira] Created: (WICKET-623) Backport call to super onComponentTag
in ExternalLink
Backport call to super onComponentTag in ExternalLink
------------------------------------------------------
Key: WICKET-623
URL: https://issues.apache.org/jira/browse/WICKET-623
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.2.7
Environment: Bug found in 1.2.6, fixed in trunk by jcompagner in rev 545131
Reporter: Johannes Fahrenkrug
Priority: Minor
ExternalLink.setOutputMarkupId(true) has no effect.
I could track this issue down to super.onComponentTag not being called at the end of ExternalLink's onComponentTag.
Adding
super.onComponentTag(tag);
to the end of ExternalLink's onComponentTag would call Component's onComponentTag which in turn would add the markup id.
Johan Compagner fixed this in trunk (rev 545131), but a backport for 1.2.7 would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-623) Backport call to super onComponentTag
in ExternalLink
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-623.
---------------------------------
Resolution: Fixed
Fixed in r546692.
> Backport call to super onComponentTag in ExternalLink
> ------------------------------------------------------
>
> Key: WICKET-623
> URL: https://issues.apache.org/jira/browse/WICKET-623
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.7
> Environment: Bug found in 1.2.6, fixed in trunk by jcompagner in rev 545131
> Reporter: Johannes Fahrenkrug
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.2.7
>
>
> ExternalLink.setOutputMarkupId(true) has no effect.
> I could track this issue down to super.onComponentTag not being called at the end of ExternalLink's onComponentTag.
> Adding
> super.onComponentTag(tag);
> to the end of ExternalLink's onComponentTag would call Component's onComponentTag which in turn would add the markup id.
> Johan Compagner fixed this in trunk (rev 545131), but a backport for 1.2.7 would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-623) Backport call to super onComponentTag
in ExternalLink
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-623:
--------------------------------
Fix Version/s: 1.2.7
Assignee: Alastair Maw
> Backport call to super onComponentTag in ExternalLink
> ------------------------------------------------------
>
> Key: WICKET-623
> URL: https://issues.apache.org/jira/browse/WICKET-623
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.7
> Environment: Bug found in 1.2.6, fixed in trunk by jcompagner in rev 545131
> Reporter: Johannes Fahrenkrug
> Assignee: Alastair Maw
> Priority: Minor
> Fix For: 1.2.7
>
>
> ExternalLink.setOutputMarkupId(true) has no effect.
> I could track this issue down to super.onComponentTag not being called at the end of ExternalLink's onComponentTag.
> Adding
> super.onComponentTag(tag);
> to the end of ExternalLink's onComponentTag would call Component's onComponentTag which in turn would add the markup id.
> Johan Compagner fixed this in trunk (rev 545131), but a backport for 1.2.7 would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.