You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/10/27 14:06:04 UTC
[jira] Created: (SB-61) Refactor ViewPreparer support
Refactor ViewPreparer support
-----------------------------
Key: SB-61
URL: http://issues.apache.org/struts/browse/SB-61
Project: Sandbox
Issue Type: Improvement
Components: Tiles
Affects Versions: 2.0
Environment: N/A (design issue)
Reporter: Antonio Petrelli
The "preparer" support in tags and definitions declared in Tiles definitions configuration files consists of parsing "preparerClass" and "preparerUrl" attributes.
Since "preparerUrl" is pretty useless, because it includes the URL in the response and can be replaced by using the "template" attribute, it should be removed.
Probably we should give support to "named preparers", i.e. preparers that are defined in Tiles configuration files (maybe a "name-class" pair) and in a new JSP tag. This way, tags can use preparers without instantiating a new one for each JSP call: in this way, preparers configuration will resemble Struts action configuration. If "named preparers" support will be implemented, probably "preparerClass" attribute should be removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SB-61) Refactor ViewPreparer support
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-61?page=all ]
David H. DeWolf resolved SB-61.
-------------------------------
Fix Version/s: 2.0
Resolution: Fixed
Fixed. Caching is currently based off of classname. Alternate "shortcuts" could be provided as another feature, but I don't see the need.
> Refactor ViewPreparer support
> -----------------------------
>
> Key: SB-61
> URL: http://issues.apache.org/struts/browse/SB-61
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (design issue)
> Reporter: Antonio Petrelli
> Assigned To: David H. DeWolf
> Fix For: 2.0
>
>
> The "preparer" support in tags and definitions declared in Tiles definitions configuration files consists of parsing "preparerClass" and "preparerUrl" attributes.
> Since "preparerUrl" is pretty useless, because it includes the URL in the response and can be replaced by using the "template" attribute, it should be removed.
> Probably we should give support to "named preparers", i.e. preparers that are defined in Tiles configuration files (maybe a "name-class" pair) and in a new JSP tag. This way, tags can use preparers without instantiating a new one for each JSP call: in this way, preparers configuration will resemble Struts action configuration. If "named preparers" support will be implemented, probably "preparerClass" attribute should be removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (SB-61) Refactor ViewPreparer support
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-61?page=all ]
David H. DeWolf reassigned SB-61:
---------------------------------
Assignee: David H. DeWolf
> Refactor ViewPreparer support
> -----------------------------
>
> Key: SB-61
> URL: http://issues.apache.org/struts/browse/SB-61
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (design issue)
> Reporter: Antonio Petrelli
> Assigned To: David H. DeWolf
>
> The "preparer" support in tags and definitions declared in Tiles definitions configuration files consists of parsing "preparerClass" and "preparerUrl" attributes.
> Since "preparerUrl" is pretty useless, because it includes the URL in the response and can be replaced by using the "template" attribute, it should be removed.
> Probably we should give support to "named preparers", i.e. preparers that are defined in Tiles configuration files (maybe a "name-class" pair) and in a new JSP tag. This way, tags can use preparers without instantiating a new one for each JSP call: in this way, preparers configuration will resemble Struts action configuration. If "named preparers" support will be implemented, probably "preparerClass" attribute should be removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SB-61) Refactor ViewPreparer support
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-61?page=comments#action_38521 ]
David H. DeWolf commented on SB-61:
-----------------------------------
Let's attack this in two different modes:
1) Remove support for both type and name
This will be addressed by issue SB-64
2) Add feature of caching preparers.
This issues will be addressed by this bug. I have started along the path by creating a configurable PreparerFactory interface which will provide ViewPreparer implementations. The default implementation does cache based off of classname. Is this caching behavior all that is required? Or, do we want to support named instances as well?
> Refactor ViewPreparer support
> -----------------------------
>
> Key: SB-61
> URL: http://issues.apache.org/struts/browse/SB-61
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: N/A (design issue)
> Reporter: Antonio Petrelli
>
> The "preparer" support in tags and definitions declared in Tiles definitions configuration files consists of parsing "preparerClass" and "preparerUrl" attributes.
> Since "preparerUrl" is pretty useless, because it includes the URL in the response and can be replaced by using the "template" attribute, it should be removed.
> Probably we should give support to "named preparers", i.e. preparers that are defined in Tiles configuration files (maybe a "name-class" pair) and in a new JSP tag. This way, tags can use preparers without instantiating a new one for each JSP call: in this way, preparers configuration will resemble Struts action configuration. If "named preparers" support will be implemented, probably "preparerClass" attribute should be removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira