You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/29 13:52:54 UTC

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1328: Fixed non-UTF8 characters.

pkarashchenko commented on code in PR #1328:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1328#discussion_r983573575


##########
netutils/thttpd/tdate_parse.c:
##########
@@ -93,11 +93,14 @@ static int strlong_compare(const void *v1, const void *v2)
 #ifdef HAVE_DAY_OF_WEEK /* Day of week not yet supported by NuttX */
 static int strlong_search(char *str, struct strlong *tab, int n, long *lP)

Review Comment:
   maybe warning can be fixed?



##########
netutils/thttpd/timers.c:
##########
@@ -293,12 +297,13 @@ void tmr_run(struct timeval *now)
         {
           next = tmr->next;
 
-          /* Since the lists are sorted, as soon as we find a timer  * that isn'tmr
-           * ready yet, we can go on to the next list
+          /* Since the lists are sorted, as soon as we find a timer that
+           * isn't ready yet, we can go on to the next list.
            */
 
           if (tmr->time.tv_sec > now->tv_sec ||
-              (tmr->time.tv_sec == now->tv_sec && tmr->time.tv_usec > now->tv_usec))
+              (tmr->time.tv_sec == now->tv_sec &&
+               tmr->time.tv_usec > now->tv_usec))

Review Comment:
   what was an issue here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org