You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2014/12/16 19:06:05 UTC

[2/2] trafficserver git commit: balancer: fix NULL sockaddr checks

balancer: fix NULL sockaddr checks


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/1e47108b
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/1e47108b
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/1e47108b

Branch: refs/heads/master
Commit: 1e47108bbeea82e80748ce1096ccece6c81d5aee
Parents: 3bb1bc1
Author: James Peach <jp...@apache.org>
Authored: Tue Dec 16 10:04:21 2014 -0800
Committer: James Peach <jp...@apache.org>
Committed: Tue Dec 16 10:04:21 2014 -0800

----------------------------------------------------------------------
 plugins/experimental/balancer/hash.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1e47108b/plugins/experimental/balancer/hash.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/balancer/hash.cc b/plugins/experimental/balancer/hash.cc
index 17c9c63..d5859e2 100644
--- a/plugins/experimental/balancer/hash.cc
+++ b/plugins/experimental/balancer/hash.cc
@@ -72,7 +72,7 @@ HashTxnSrcaddr(TSHttpTxn txn, TSRemapRequestInfo *, MD5_CTX * ctx)
   struct sockaddr const * sa;
 
   sa = TSHttpTxnClientAddrGet(txn);
-  if (txn) {
+  if (sa) {
     MD5_Update(ctx, sa, sockaddrlen(sa));
     TSDebug("balancer", "%s(addr[%zu]]", __func__, sockaddrlen(sa));
   }
@@ -85,7 +85,7 @@ HashTxnDstaddr(TSHttpTxn txn, TSRemapRequestInfo *, MD5_CTX * ctx)
   struct sockaddr const * sa;
 
   sa = TSHttpTxnIncomingAddrGet(txn);
-  if (txn) {
+  if (sa) {
     MD5_Update(ctx, sa, sockaddrlen(sa));
     TSDebug("balancer", "%s(addr[%zu]]", __func__, sockaddrlen(sa));
   }