You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/08 06:42:27 UTC
[GitHub] [ozone] pakapoj-tul commented on a change in pull request #2343: HDDS-5193. change to use getShortUserName instead of getUsername
pakapoj-tul commented on a change in pull request #2343:
URL: https://github.com/apache/ozone/pull/2343#discussion_r665911628
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -541,7 +541,7 @@ private static void verifySpaceQuota(long quota) throws OMException {
* @return listOfAcls
* */
private List<OzoneAcl> getAclList() {
- return OzoneAclUtil.getAclList(ugi.getUserName(), ugi.getGroupNames(),
+ return OzoneAclUtil.getAclList(ugi.getShortUserName(), ugi.getGroupNames(),
Review comment:
Hi @xiaoyuyao as i checked the ACLs assignment was happened [here](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java#L249) and where ACLs was given from the client side so just wanna confirm with you first that we ignore this and build a new one from `userInfo`?
[Request payload.txt](https://github.com/apache/ozone/files/6782127/Request.payload.txt)
Another question is where should I call the `getRemoteUser()`?, I try to called it in [here](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java#L249) but it failed tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org