[GitHub] [druid] zachjsh commented on a diff in pull request #14319: add configurable ColumnTypeMergePolicy to SegmentMetadataCache

["zachjsh (via GitHub)" <gi...@apache.org>]

zachjsh commented on code in PR #14319:
URL: https://github.com/apache/druid/pull/14319#discussion_r1202932517


##########
processing/src/main/java/org/apache/druid/segment/NestedDataColumnMerger.java:
##########
@@ -93,6 +93,9 @@ public void writeMergedValueDictionary(List<IndexableAdapter> adapters) throws I
         final IndexableAdapter.NestedColumnMergable mergable = closer.register(
             adapter.getNestedColumnMergeables(name)
         );
+        if (mergable == null) {

Review Comment:
   Was this existing bug, or does this change somehow allow `mergable` to be nullable now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org