You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Mona Chitnis (JIRA)" <ji...@apache.org> on 2012/08/30 03:40:07 UTC
[jira] [Created] (OOZIE-981) Subworkflow lib not found in classpath
when parent workflow lib overwrites it
Mona Chitnis created OOZIE-981:
----------------------------------
Summary: Subworkflow lib not found in classpath when parent workflow lib overwrites it
Key: OOZIE-981
URL: https://issues.apache.org/jira/browse/OOZIE-981
Project: Oozie
Issue Type: Bug
Affects Versions: 3.3.0
Reporter: Mona Chitnis
Assignee: Mona Chitnis
Fix For: 3.3.0
OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-981) Subworkflow lib not found in classpath
when parent workflow lib overwrites it
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-981:
-------------------------------
Fix Version/s: trunk
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0, trunk
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444644#comment-13444644 ]
Hadoop QA commented on OOZIE-981:
---------------------------------
Testing JIRA OOZIE-981
Cleaning local svn workspace
{code}
----------------------------
+1 PATCH_APPLIES
CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 902
Tests failures: 1
Tests errors: 1
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
{code}
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/71/
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-981) Subworkflow lib not found in classpath
when parent workflow lib overwrites it
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-981:
-------------------------------
Attachment: OOZIE-981v1.patch
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445506#comment-13445506 ]
Mona Chitnis commented on OOZIE-981:
------------------------------------
Addressed comment. Added more test to check job success
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-981) Subworkflow lib not found in classpath
when parent workflow lib overwrites it
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-981:
-------------------------------
Attachment: OOZIE-981.patch
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449349#comment-13449349 ]
Mona Chitnis commented on OOZIE-981:
------------------------------------
+1'd. comments incorporated and tests dont fail. can this be committed so our tests can pick up fixed code from trunk?
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0, trunk
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445603#comment-13445603 ]
Hadoop QA commented on OOZIE-981:
---------------------------------
Testing JIRA OOZIE-981
Cleaning local svn workspace
{code}
----------------------------
+1 PATCH_APPLIES
CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 2 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 905
Tests failures: 0
Tests errors: 0
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
{code}
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/75/
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445556#comment-13445556 ]
Virag Kothari commented on OOZIE-981:
-------------------------------------
+1
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-981) Subworkflow lib not found in
classpath when parent workflow lib overwrites it
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445403#comment-13445403 ]
Alejandro Abdelnur commented on OOZIE-981:
------------------------------------------
patch looks good, only NIT is
{code}
+ // if property already exists, should not overwrite
+ if(conf.get(name) != null) {
+ continue;
+ }
+ conf.set(name, value);
{code}
I'd do instead:
{code}
+ // if property already exists, should not overwrite
+ if(conf.get(name) == null) {
+ conf.set(name, value);
+ }
{code}
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-981) Subworkflow lib not found in classpath
when parent workflow lib overwrites it
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated OOZIE-981:
-------------------------------------
Fix Version/s: (was: trunk)
> Subworkflow lib not found in classpath when parent workflow lib overwrites it
> -----------------------------------------------------------------------------
>
> Key: OOZIE-981
> URL: https://issues.apache.org/jira/browse/OOZIE-981
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.3.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Fix For: 3.3.0
>
> Attachments: OOZIE-981.patch, OOZIE-981v1.patch
>
>
> OOZIE-567 addresses the bug mentioned in the title here - by adding the subworkflow libpath to the classpath in addition to parent workflow libpath. OOZIE-871 reverted this to avoid duplicate values, but the subworkflow libpath should not be overwritten by parent workflow's libpath. Hence, tackling this bug here.
> Existing testcase modified slightly to demonstrate the expected behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira